Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 411577

Summary: [Contributions] Customize Perspective has hiding conflicts for toolbars and menus
Product: [Eclipse Project] Platform Reporter: Jens Kuebler <kuebler>
Component: UIAssignee: Paul Webster <pwebster>
Status: VERIFIED FIXED QA Contact: Paul Webster <pwebster>
Severity: normal    
Priority: P3 CC: pwebster
Version: 4.3Keywords: helpwanted
Target Milestone: 4.4 M3   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on:    
Bug Blocks: 418022, 420956    
Attachments:
Description Flags
Add prefix check none

Description Jens Kuebler CLA 2013-06-25 06:08:13 EDT
Created attachment 232723 [details]
Add prefix check

If a toolbar and a menu has the same id and both elements shell be hidden updateHiddenElements does not consider the prefix in its containment check. 
The outcome is that only one of the item (either a toolbar item or a menu item) may be hidden at a time.

The fix is trivial in adding the prefix to the contains check. Then both items may be hidden at a time.

Reproduction can be done by hiding the file menu and toolbar items
Comment 1 Jens Kuebler CLA 2013-08-28 11:44:43 EDT
Is there any way to get this into 4.3.1 as the change is really trivial ?
Comment 2 Paul Webster CLA 2013-09-10 15:08:38 EDT
Jens, could you please sign your CLA?

PW
Comment 3 Jens Kuebler CLA 2013-09-25 03:49:02 EDT
Done.
Comment 5 Paul Webster CLA 2013-10-29 10:01:13 EDT
In 4.4.0.I20131028-2000

PW