Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 411532

Summary: Save button remains on toolbar after editor goes away
Product: [ECD] Orion Reporter: Mark Macdonald <mamacdon>
Component: ClientAssignee: Gabriel Luong <gabriel.luong>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: gabriel.luong, Silenio_Quarti, simon_kaegi
Version: 3.0Flags: mamacdon: review+
Target Milestone: 4.0 M1   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Mark Macdonald CLA 2013-06-24 15:06:33 EDT 
1. Open a file in the editor page
2. Use the sidebar navigator to delete the file you are editing
3. The editor goes away (as expected) but a nonfunctional "Save" button remains on the toolbar.
Comment 2 Silenio Quarti CLA 2013-06-25 13:51:17 EDT 
I do not think inputManager.js should know about pageActions. The code should probably go in a "InputChanged" listener.
Comment 3 Gabriel Luong CLA 2013-06-25 14:42:01 EDT 
https://github.com/gabrielluong/orion.client/commit/7cb3da66c52da0f2200e56ce48727f9638a68754

I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL
Comment 4 Gabriel Luong CLA 2013-06-25 14:43:11 EDT 
This builds on my patch in Bug 411607. Thanks Silenio!
Comment 5 Gabriel Luong CLA 2013-06-25 15:18:42 EDT 
Disregard patch in Comment 1
Comment 6 Gabriel Luong CLA 2013-06-25 15:27:50 EDT 
disregard the patch in Comment 3. Need to check when there is no editor before removing the toolbar.
Comment 7 Gabriel Luong CLA 2013-06-26 09:40:41 EDT 
https://github.com/gabrielluong/orion.client/commit/597daf8097d530ef5b3ed9aee9fde46ba5e849e1

I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL
Comment 8 Mark Macdonald CLA 2013-06-26 10:09:46 EDT 
(In reply to comment #7)

Looks fine, will push when master reopens for 4.0