Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 411503

Summary:	Hidden tabs' filenames should be bolded in "Show List" drop-down of tabbed editor view.
Product:	[Eclipse Project] Platform	Reporter:	Paul Webster <pwebster>
Component:	UI	Assignee:	Platform-UI-Inbox <Platform-UI-Inbox>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	akafakir, blessedgeek, bournenoir, daniel_megert, emoffatt, griefsong, harvananz, mangino, markus.kell.r, mauromol, pwebster, wim.jongman
Version:	4.2	Keywords:	helpwanted
Target Milestone:	4.3.1
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:	385987
Bug Blocks:

Description Paul Webster

2013-06-24 11:12:44 EDT

Backport to 4.3.1

+++ This bug was initially created as a clone of Bug #385987 +++

Build Identifier: Version: Juno Release Build id: 20120614-1722

When so many files are being edited that all tabs cannot be shown, a double-arrow icon appears to the right of the right-most tab, along with a number indicating the number of hidden tabs. When clicking this icon, a drop-down is displayed showing all files open in that tab group. Prior to Juno, the hidden tabs' filenames appeared in bolded text in this list. However, in Juno, the hidden tabs' filenames are not bolded.

Having the hidden entries bolded is a very nice usability feature because it allows the user to easily see the groups of hidden and visible files that are open.

Reproducible: Always

Steps to Reproduce:
1. Open enough files that some of their tabs become hidden.
2. Click on the "Show List" double-arrow icon to the right of the right-most visible file tab.
3. Note that the hidden files' names are not bolded.

Comment 1 Paul Webster

2013-08-01 15:24:49 EDT

https://git.eclipse.org/r/15056 - main fix
https://git.eclipse.org/r/15057 - fix a test renderer


Eric, could I get you to review this for 4.3.1.

You can fetch 15057 from Gerrit to get both fixes in your workspace at the same time.

PW

Comment 2 Eric Moffatt

2013-08-02 13:05:55 EDT

Reviewed and pushed both patches:

Implementation:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_3_maintenance&id=a9b13322cc384a3454a0979cfea72592705106ed

Test Renderer fix:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_3_maintenance&id=0b2062495bbfb6d6ea65661b5a4513f3924c3ca2

Comment 3 Dani Megert

2013-08-12 08:53:21 EDT

Verified in M20130807-1400.

We should revisit the usage of bold for hidden items though, see bug 70982.