Bugzilla – Full Text Bug Listing
| Summary: | Clicking OK in the Open Commit dialog produces an error | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Mark Macdonald <mamacdon> |
| Component: | Git | Assignee: | Simon Kaegi <simon_kaegi> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | simon_kaegi |
| Version: | 3.0 | Flags: | john.arthorne:
review+
simon_kaegi: review+ |
| Target Milestone: | 3.0 RC3 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
Looking at the code we should just remove the OK button. This makes it consistent with other find dialogs. pushed. |
1. Go to the Repository page for a repo. 2. Press Ctrl+Shift+H. You will see a slideout appear. 3. Click the "More" button on the slideout. A dialog appears, asking for a commit ID. 4. Paste any commit ID into the box. 5. Click OK to the dialog. It closes, and a JS error appears in the console: > Uncaught TypeError: Object #<OpenCommitDialog> has no method '_execute' OpenCommitDialog.js:58 > buttons.push.callback OpenCommitDialog.js:58 > (anonymous function) uiUtils.js:233 I expected it to pop up a window showing the commit details -- same as if I had pasted the commit ID into the slideout. I checked Orion 2.0 and the same error exists there, so this is not a regression.