Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 411187

Summary: Search: client side should handle time out when requesting search.
Product: [ECD] Orion Reporter: libing wang <libingw>
Component: ClientAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ken_walker, mamacdon, simon_kaegi
Version: 3.0Flags: mamacdon: review+
simon_kaegi: review+
Target Milestone: 3.0 RC3   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description libing wang CLA 2013-06-19 17:10:05 EDT 
Currently if the search response from the server takes more than 15 seconds(e.g. in orionHub), the "searching..." status message just hangs there.
1.We should probably increase the time out.
2.In the meanwhile if time out happens, we should render a "time out" message instead of "searching...".
Comment 1 libing wang CLA 2013-06-20 08:29:55 EDT 
To test, I was able to set the timeout as 1000 ms and reproduce the issue.
I think we should fix this for RC3.
The real timeout is 15000 ms. This should be good enough for most of the cases. But if timeout really happens we can pop up a message saying "Search response from the server is time out. Please try again later".
Comment 2 Ken Walker CLA 2013-06-20 08:32:21 EDT 
"The response from the server timed out. Try your search again"
Comment 4 libing wang CLA 2013-06-20 10:23:31 EDT 
To test, you can temporarily change the timeout in fileimpl.js, to 1000 ms.
Then open the search page and search. You will see the error pops up in the status bar.
If you refresh the browser you will see the result because the previous result is cached on the server side and the response takes less than 1000 ms.
Comment 5 libing wang CLA 2013-06-20 10:24:34 EDT 
Line 544 at fileimpl.js to change the timeout.
Comment 6 Mark Macdonald CLA 2013-06-20 10:51:28 EDT 
Seems ok. The change is pretty localized.
Comment 7 Mark Macdonald CLA 2013-06-20 10:52:13 EDT 
My only real suggestion would be to add a period at the end of the error message, i.e. 
> "${0}. Try your search again."
>                             ^
Comment 8 libing wang CLA 2013-06-20 11:05:34 EDT 
(In reply to comment #7)
> My only real suggestion would be to add a period at the end of the error
> message, i.e. 
> > "${0}. Try your search again."
> >                             ^
Thanks, pushed the second fix in the same remote branch.
Comment 10 Simon Kaegi CLA 2013-06-20 12:50:54 EDT 
pushed