Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 410930

Summary: Splitter can be dragged past the left edge of the page
Product: [ECD] Orion Reporter: Silenio Quarti <Silenio_Quarti>
Component: ClientAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ken_walker, libingw, mamacdon
Version: 3.0Flags: mamacdon: review+
ken_walker: review+
Target Milestone: 3.0 RC3   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Patch file
none
Patch file with EOF, works now when you apply it from Orion none

Description Silenio Quarti CLA 2013-06-17 11:36:55 EDT 
1) Open the editor page (or any other page).
2) Drag the splitter to left. 

Note that you are able to drag it past the left edge of the browser and if you release the mouse there, you will not be able to bring it back.
Comment 1 libing wang CLA 2013-06-17 11:46:48 EDT 
The last position of the splitter is stored in the localStorage. Although you can restore it by localStorage.clear() but I think it is a bad problem. I will fix it for RC3.
Comment 2 libing wang CLA 2013-06-17 14:52:55 EDT 
Created attachment 232460 [details]
Patch file

Patch file
Comment 3 libing wang CLA 2013-06-17 15:06:58 EDT 
Seems applying patch does not works well, I created remote branch named bug410930.
Comment 4 libing wang CLA 2013-06-17 15:19:10 EDT 
To test the vertical splitter, you can open the replace page.
Comment 5 Mark Macdonald CLA 2013-06-17 15:39:20 EDT 
tested, works well
Comment 6 libing wang CLA 2013-06-17 15:43:58 EDT 
(In reply to comment #3)
> Seems applying patch does not works well, I created remote branch named
> bug410930.
BTW, the "show patch" feature from the git status page only shows the patch contents. I copied the contents and create the patch file manually.
It was my fault when I paste the contents into the patch file, without add the EOF in the file.
If I add an empty line in the patch file, the apply patch works.
Comment 7 libing wang CLA 2013-06-17 15:44:33 EDT 
Created attachment 232469 [details]
Patch file with EOF, works now when you apply it from Orion
Comment 8 Ken Walker CLA 2013-06-18 12:58:04 EDT 
Verified fix