| Summary: | Git repository rendering issues | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Gabriel Luong <gabriel.luong> | ||||
| Component: | Client | Assignee: | Gabriel Luong <gabriel.luong> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | simon_kaegi, Szymon.Brandys | ||||
| Version: | 3.0 | Flags: | simon_kaegi:
review+
|
||||
| Target Milestone: | 3.0 RC3 | ||||||
| Hardware: | PC | ||||||
| OS: | Mac OS X | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Fixed duplicate rendering of status (1) and refactor status rendering in working directory node. https://github.com/gabrielluong/orion.client/commit/5e359b92c714be6c58684e8ee790b125050bedd6 https://orion.eclipse.org/git/reviewRequest.html#https://github.com/gabrielluong/orion.client.git_5e359b92c714be6c58684e8ee790b125050bedd6 I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL ^The above patch is already pushed this was pushed here by Simon http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=aab674a658fc9251fa911d02dc45af18a1f61cff |
Created attachment 232363 [details] Duplicate status rendered In gitRepositoryExplorer.js, 1. Render duplicate status. See attachment. 2. Empty divs used for spacing. 3. detailsView.style.overflow = "vbox stretch details-view" does not add the style. Overall, file could probably use a cleanup - adding nls, formatting