Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 410776

Summary: Git repository rendering issues
Product: [ECD] Orion Reporter: Gabriel Luong <gabriel.luong>
Component: ClientAssignee: Gabriel Luong <gabriel.luong>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: simon_kaegi, Szymon.Brandys
Version: 3.0Flags: simon_kaegi: review+
Target Milestone: 3.0 RC3   
Hardware: PC   
OS: Mac OS X   
Whiteboard:
Attachments:
Description Flags
Duplicate status rendered none

Description Gabriel Luong CLA 2013-06-14 00:19:14 EDT
Created attachment 232363 [details]
Duplicate status rendered

In gitRepositoryExplorer.js, 
1. Render duplicate status. See attachment.
2. Empty divs used for spacing.
3. detailsView.style.overflow = "vbox stretch details-view" does not add the style.

Overall, file could probably use a cleanup - adding nls, formatting
Comment 1 Gabriel Luong CLA 2013-06-14 00:25:00 EDT
Fixed duplicate rendering of status (1) and refactor status rendering in working directory node.

https://github.com/gabrielluong/orion.client/commit/5e359b92c714be6c58684e8ee790b125050bedd6
https://orion.eclipse.org/git/reviewRequest.html#https://github.com/gabrielluong/orion.client.git_5e359b92c714be6c58684e8ee790b125050bedd6

I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL
Comment 2 Gabriel Luong CLA 2013-06-20 12:27:26 EDT
^The above patch is already pushed
Comment 3 Szymon Brandys CLA 2013-06-21 03:27:36 EDT
See comment 2.