| Summary: | Support for CAS SSO | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Abhijit Gurav <abhijit.gurav> | ||||||
| Component: | Mylyn | Assignee: | Project Inbox <mylyn-triaged> | ||||||
| Status: | CLOSED MOVED | QA Contact: | |||||||
| Severity: | enhancement | ||||||||
| Priority: | P4 | CC: | andermaj, joerg.sesterhenn, steffen.pingel, tom.gl | ||||||
| Version: | 1.0 | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 328723 | ||||||||
| Attachments: |
|
||||||||
|
Description
Abhijit Gurav
Correcting typo mistake in last paragraph, It works fine but since when tried to add that server and job to build view and refresh connector. It's called internal instance of RestfulHudsonClient which of course don't have valid cookies and it's fails. This sounds like an enhancement request to me. Hi Tomasz, Thanks for reply, should I consider that, the above request will be taken care in new upcoming release or do we have seperate process to have this. Please suggest. Thanks and Regards, Abhijit Gurav Thank you for your request. It does not fall into the core scope of the project and due to time constraints we are unable to resolve it at the moment. The bug has been marked helpwanted though to indicate that we would be happy to support a community contribution to resolve it. Created attachment 232714 [details]
Added CookieStore
Hi Steffen,
Thanks for reply,
I worked on the same, my first way was to make our own RestfulHudsonClient and contribute through extension point.
But As I observed in org.eclipse.mylyn.builds.internal.core.operations.RefreshSession
while refreshing Build view, through org.eclipse.mylyn.internal.builds.ui.BuildsUiInternal
it takes different instance of RestfulHudsonClient.
Hence I came with new approach to add ability to cookies in RestfulHudsonClient, with help of org.eclipse.mylyn.commons.repositories.core.RepositoryLocation
As we set some of the UserCredentials through RepositoryLocation only.
So from user point of view, who wish to add some servers and plans programmatically in BuildsView.
They can create desired RepositoryLocation with valid cookies added to it.Like, location.setCookieStore(cookieStore);
With other part same as what used to perform by taking HudsonServerBehaviour and calling desired method.
I am attaching two patches
1) Added-cookieStore.patch : this is for RepositoryLocation from org.eclipse.mylyn.commons.repositories.core project.
2) Setting-Cookies-if-provided-by-Repository-location.patch : this is for RestfulHudsonClient from org.eclipse.mylyn.hudson.core for adding ability to add cookies in client.
Let me know the validity of this patch and can this be added to next future released.
Regards,
Abhijit Gurav
Created attachment 232715 [details]
Setting Cookies if provided
Adding 2nd patch (Setting-Cookies-if-provided-by-Repository-location.patch)
Hi Team, Can you please let me know that, is my patch is validated and if all ok with patch then when that can be integrated for future release. Thanks and Regards, Abhijit Gurav Please raise the priority of this bug. SSO via CAS is not unusual and we need it to be supported! Mylyn has been restructured, and our issue tracking has moved to GitHub [1]. We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub. [1] https://github.com/orgs/eclipse-mylyn |