Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 410628

Summary:	Refactor commit tooltip dialog
Product:	[ECD] Orion	Reporter:	Gabriel Luong <gabriel.luong>
Component:	Client	Assignee:	Gabriel Luong <gabriel.luong>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	mamacdon
Version:	3.0	Flags:	mamacdon: review+
Target Milestone:	3.0 RC2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Gabriel Luong

2013-06-12 12:40:45 EDT

Refactor the commit tooltip dialog to remove unnecessary div elements, and added nls annotations. The tooltip dialog used divs as line breaks as described in Bug 410548. The author image doesn't need to be wrapped in a div that is floated left since the image class already has a css style to float left. 

https://github.com/gabrielluong/orion.client/commit/b8410d50589601ac186687be8419742005957039
https://orion.eclipse.org/git/reviewRequest.html#https://github.com/gabrielluong/orion.client.git_b8410d50589601ac186687be8419742005957039

I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL

Comment 1 Mark Macdonald

2013-06-12 17:42:13 EDT

Seems fine. Renders the same as before, but the DOM structure is cleaner.
I was not able to test the Open Commit part of this fix due to bug 410661.

anyway, pushed
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=de02e6e

Comment 2 Mark Macdonald

2013-06-12 17:52:10 EDT

I was not able to test the "Open Commit" UI changes due to bug 410661.