Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 410601

Summary: Search: Context tool tip popup has bad contrast.
Product: [ECD] Orion Reporter: libing wang <libingw>
Component: ClientAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: mamacdon
Version: 3.0Flags: mamacdon: review+
Target Milestone: 3.0 RC2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description libing wang CLA 2013-06-12 09:51:02 EDT 
In the search result page if current selection is on a matching line, using right arrow key pops up a 5 line context tip.
The UI is consuming the Orion tooltip widget but the back ground color was changed to black. This makes no contrast to see the context.
Comment 1 libing wang CLA 2013-06-12 11:02:52 EDT 
Patch:

diff --git a/bundles/org.eclipse.orion.client.ui/web/orion/globalSearch/globalSearch.css b/bundles/org.eclipse.orion.client.ui/web/orion/globalSearch/globalSearch.css
index e9c1ab7..4d389de 100644
--- a/bundles/org.eclipse.orion.client.ui/web/orion/globalSearch/globalSearch.css
+++ b/bundles/org.eclipse.orion.client.ui/web/orion/globalSearch/globalSearch.css
@@ -17,10 +17,6 @@
 	color: #666666;	
 }
 
-.search_context_tip {
-	background: #FFFFCC;
-}
-
 .search_report {
 	padding-left: 5px; 
 	padding-right: 5px;
diff --git a/bundles/org.eclipse.orion.client.ui/web/orion/searchExplorer.js b/bundles/org.eclipse.orion.client.ui/web/orion/searchExplorer.js
index 7c4b36b..2b7c480 100644
--- a/bundles/org.eclipse.orion.client.ui/web/orion/searchExplorer.js
+++ b/bundles/org.eclipse.orion.client.ui/web/orion/searchExplorer.js
@@ -173,7 +173,7 @@
             span = lib.node(this.getFileIconId(item));
             _empty(span);
         } else {
-        	this.explorer._prepareFilter(item);
+			this.explorer._prepareFilter(item);
         }
     };
 
@@ -235,14 +235,14 @@
     };
 
     SearchResultRenderer.prototype.generateContextTip = function(detailModel) {
-        var tableNode = _createElement('table', "search_context_tip"); //$NON-NLS-1$ //$NON-NLS-0$
+        var tableNode = _createElement('table'); //$NON-NLS-1$ //$NON-NLS-0$
         for (var i = 0; i < detailModel.context.length; i++) {
             var lineDiv = _createElement('tr', null, null, tableNode); //$NON-NLS-0$
             var lineTd;
             if (detailModel.context[i].current) {
                 lineTd = _createElement('td', null, null, lineDiv); //$NON-NLS-0$
                 lineTd.noWrap = true;
-                var span = _createElement('span', "primaryColumn", null, lineTd); //$NON-NLS-1$ //$NON-NLS-0$
+                var span = _createElement('span', null, null, lineTd); //$NON-NLS-1$ //$NON-NLS-0$
                 this.generateDetailHighlight(detailModel, span); //$NON-NLS-1$ //$NON-NLS-0$
             } else {
                 lineTd = _createElement('td', null, null, lineDiv); //$NON-NLS-0$
Comment 2 libing wang CLA 2013-06-12 11:11:56 EDT 
reviewed with Mark and push the fix with:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=402fe59f7d7c4ffb6895618f424d98c74d2f56cb