| Summary: | If banner/footer toggled away breadcrumb updates are lost | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Ken Walker <ken_walker> |
| Component: | Client | Assignee: | Anthony Hunter <ahunter.eclipse> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | mamacdon |
| Version: | 3.0 | Flags: | mamacdon:
review+
|
| Target Milestone: | 3.0 RC2 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Ken Walker
The layout of the breadcrumbs is being done by taking advantage of the offsetWidth attribute. The value of offsetWidth is always zero when the display is set to none, which means the calculations are incorrect when hidden. Rather than using display: none to hide, we can use visibility: hidden instead, which results in offsetWidth continuing to be valid and the breadcrumbs showing properly when unhidden with the keyboard shortcut. The change is at https://github.com/ahunter-orion/orion.client/commit/037529157a2a3fc589d66c7f598853ecb6b18f09 I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL |