Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 410319

Summary:	Default eclipse MenuItems have non-complete accelerator text
Product:	[RT] RAP	Reporter:	Yury <swimmer_86>
Component:	JFace	Assignee:	Project Inbox <rap-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	rsternberg
Version:	2.1
Target Milestone:	2.2 M3
Hardware:	All
OS:	All
Whiteboard:	sr212

Description Yury

2013-06-10 06:07:15 EDT

Discussion is started here - http://www.eclipse.org/forums/index.php/t/488631/.

Predefined eclipse menu items are displayed without full accelerator text. For example, action File->Save is displayed with text "Save S" instead of "Save Ctrl+S".
The cause of this is in org.eclipse.jface.bindings.keys.formatting.NativeKeyFormatter.sortModifierKeys(int)

protected int[] sortModifierKeys(final int modifierKeys) {
...

		if (Util.isWindows()) {
...

		} else if (Util.isGtk() || Util.isMotif()) {
...

		} else if (Util.isMac()) {
...
		}

		return sortedKeys;
	}

All "if" blocks return false.

Comment 1 Yury

2013-06-10 06:22:09 EDT

Probably the best way is provide default "else" block with windows behavior. But that is just my opinion.

Comment 2 Ivan Furnadjiev

2013-06-10 06:25:02 EDT

(In reply to comment #1)
> Probably the best way is provide default "else" block with windows behavior. But
> that is just my opinion.
I'm fine with this as well.

Comment 3 Yury

2013-10-03 06:35:32 EDT

Any progress with this issue?

Comment 4 Ivan Furnadjiev

2013-10-03 06:56:19 EDT

(In reply to comment #1)
> Probably the best way is provide default "else" block with windows behavior.
Fixed as suggested in master with commit df625aa9b1ca1323a810129fcf47e9c4c90a6543.

Comment 5 Ralf Sternberg

2014-01-27 11:10:23 EST

+1 for backporting to 2.1.2. There's a different version in master. For the service release, I think either version is fine.

Comment 6 Ivan Furnadjiev

2014-01-29 03:58:24 EST

Backported to 2.1-maintenance branch with change https://git.eclipse.org/r/21229.