Bug 410302

Description Judith Gull 2013-06-10 04:13:00 EDT

Comments in bug 388722 by Bertin Kiekebosch:

In Swing, the text of very small items is painted outside the calendarItem. Although technically the code is correct, the effect of using FontMetrics.getAscent is that there appears some whitespace above the text. This is perfect when there is enough space and there are some characters in some fonts that might use this space.

Possible fix: If the calendarItem has a small height, then working with an ofset of -4 gives better results. There are some characters that are not totally visible then, for example Ä, Ü are drawn without a umlaut but in most cases it is perfectly readable and the text starts on the item and not below. Without the correction, if there are more small items below each other, the text appears to be on the wrong item.

See the shortAppointmentsNoCorrection.PNG, shortAppointmentsMinus2Correction.PNG and shortAppointmentsMinus4Correction.PNG for how it looks in out screen.

Can be fixed by using an ofset of -4 (in class LargeCalendarCell). When made dynamically this negative ofset is only usen when neccessary

if (cc.isLabeled()) {
g.setColor(getForeground());
String s = m_dateChooser.getModel().getLabel(cc.getItem(), getRepresentedDate());
int centery = Math.max(0, (r.height – fm.getAscent()) / 2);
g.setClip(r.x, r.y + centery, r.width, fm.getHeight());
if (s != null) {
int yCorrection = 0;
if (fm.getAscent() > r.height) {
yCorrection = 4;
}
g.drawString(s, r.x + 3, r.y + centery + fm.getAscent() - yCorrection);
}
}

This change is not in the patch because I like to discuss it first.