Bugzilla – Full Text Bug Listing
| Summary: | Need pass for icon sprites for 3.0 release | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Mark Macdonald <mamacdon> |
| Component: | Client | Assignee: | Anthony Hunter <ahunter.eclipse> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | Flags: | mamacdon:
review+
|
| Version: | 3.0 | ||
| Target Milestone: | 3.0 RC2 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
Raised a separate Bug 410757 Mergesquash image needs to be added to the git sprites images.css is now cleaned up and only contains the image sprite. Added a core_sprites.html to help me see what is in the image. Added a core_sprites.sh to create the zip file of the images to upload to the CSS Sprite Generator. Updated core_sprites.png, the new sprite. New collapseAll image: renamed collapse.png to collapseAll.png and deleted collapseAll.gif New expandAll image: renamed expand.png to expandAll.png and deleted expandAll.gif Added add-content to the sprite. Added compare-addition to the sprite. Added compare-removal to the sprite. Added copy-folder to the sprite. Added hamburger to the sprite. Added gear to the sprite. Added list to the sprite. Added go-up to the sprite. ( renamed moveUp.png to go-up.png ). Added list to the sprite. Added orion-logo to the sprite. Renamed makeFavourite to favorite to match the image. Renamed info to information to match the image. Removed extra padding on the hamburger in ide.css. Removed unused entries from the sprite, since there are no code references to them (easy to add them back in if we need to now): core-sprite-diff-border-sel core-sprite-diff-border core-sprite-diff-empty-add-word-border core-sprite-diff-empty-del-word-border core-sprite-diff-empty-word-border-black core-sprite-favorite_sml core-sprite-glass core-sprite-html core-sprite-javascript core-sprite-menu_twistie core-sprite-orion-transparent core-sprite-problem core-sprite-progress_running core-sprite-splitterleft core-sprite-splitterright The change is at: https://github.com/ahunter-orion/orion.client/commit/69435c5a2597456c1448067d29a342a57c4f0f82 I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL. Thanks Anthony. Pushed: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=a60d714 I added one additional commit ( cd6ba3a ) with a minor change, which is restoring the logoFooter class (and moving it into ide.css). Ideally our HTML files should only contain class names, and the actual style info should be in the .css files. I did noticed a few nits with sprites being misaligned or not padded correctly, opened bug 410867 for those. |
We have new icons that need to be incorporated into CSS sprites: * hamburger menu icon (images/hamburger.png) * new ("[+]" icon) (images/addcontent.png) * actions (gear icon) (images/gear.png) * user menu icon (../images/silhouette.png) * local editor settings (../images/wrench.png) * Go Up (up arrow icon) (../images/moveUp.png)