Bugzilla – Full Text Bug Listing
| Summary: | There should be a way to override global css without modifying ide.css | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Malgorzata Janczarska <malgorzata.tomczyk> |
| Component: | Client | Assignee: | Malgorzata Janczarska <malgorzata.tomczyk> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | ken_walker, Szymon.Brandys |
| Version: | 3.0 | Flags: | Szymon.Brandys:
review+
|
| Target Milestone: | 3.0 RC2 | ||
| Hardware: | PC | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Malgorzata Janczarska
This is a commit that I would like to merge: https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?h=Bug410192&id=16466c19db6b48cb77325442e07fd987e21d19a0 I added css/customide.css file that can be overwritten by other contributor to apply some custom css. Ken, it's already RC2. Do I need your +1 to commit this? Another way to solve this problem is to use the theme.css we already have instead of adding another css. This would however require similar changes, because right now styles from theme.css are overwritten by ide.css and it should be the other may around. (In reply to comment #2) > Another way to solve this problem is to use the theme.css we already have > instead of adding another css. This would however require similar changes, > because right now styles from theme.css are overwritten by ide.css and it should > be the other may around. Those are the changes that need to be made to make theme.css have higher priority then ide.css. For original Orion this changes nothing, because styles in theme.css do not overlap with styles in ide.css. Ken said I don't need his +1 if it's not a feature, so Szymon's review is enough to merge it. merged. |