Bug 410144

Description Anamaria Pradais 2013-06-07 04:55:22 EDT

In a class Utilities I have the following code that is meant to open a pop-up box and show a validation failed message when a button from a certain Shell is clicked (as a Save button in a form that performs validation before actually taking a desired action):
public static void showErrorMessage(Shell parent, final String msg) {
 final Shell parentInst = parent;
 logger.error(msg);
 parent.getDisplay().asyncExec(new Runnable() {
  @Override
  public void run() {
   MessageBox messageBox = new MessageBox(parentInst, SWT.ERROR | SWT.OK);
   messageBox.setMessage(msg);
   DialogUtil.open(messageBox, null);
  }
 });
}
Before opening the MessageBox the focus is forced to move to the Text field that failed validation and select all content. After closing the MessageBox this focus in the underlying Shell should be resumed. This used to work perfectly in version 1.5 but doesn't work anymore after updating to 2.1M2. 

Tried to fix it like this:
public static void showErrorMessage(Shell parent, final String msg) {
 final Shell parentInst = parent;
 final Control focusedControl = parent.getDisplay().getFocusControl();// checked this and is what I expected
 parent.getDisplay().asyncExec(new Runnable() {
  @Override
  public void run() {
   MessageBox messageBox = new MessageBox(parentInst, SWT.ERROR | SWT.OK);
   messageBox.setMessage(msg);
   DialogUtil.open(messageBox, new DialogCallback() {
    @Override
    public void dialogClosed(int returnCode) {
     if (null != focusedControl)
      focusedControl.forceFocus(); //not working and returns false
    }
   });
  }
 });
}

After some further investigations I've determined that the method call focusedControl.isActive() which is used in forceFocus() returns false causing the forceFocus to have no effect because even if the MessageBox is closing when this action is executed it is probably still considered as being on top of the Shell where I would want the focus to return.