Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 409875

Summary:	Navigator: duplicated "Actions" menus flicker when changing folders
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Client	Assignee:	Gabriel Luong <gabriel.luong>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ken_walker, simon_kaegi
Version:	3.0	Flags:	mamacdon: review+ simon_kaegi: review+ ken_walker: review+
Target Milestone:	3.0 RC3
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mark Macdonald

2013-06-04 12:55:24 EDT

1. Navigate into a folder (or if you are already on the Navigator, you can reload the page -- same effect).
2. As the toolbar draws itself, you will briefly see 2 Actions menus on the screen (2 "gear" icons, in other words).
3. After an instant, one of them vanishes and you are left with just a single Actions menu.

There's probably an superfluous call to renderCommands() in the explorer somewhere that should be removed.

Comment 1 Gabriel Luong

2013-06-17 14:31:13 EDT

It seems the duplicate "Actions" menu effect was created due to 2 "New" menus being created with the "Actions" menu appearing as the third menu item. I would like to take a deeper look at what is going on with the constant rendering and destroying of the buttons. The "New" and "Action" menus would be render and then destroyed and re-rendered with the correct dropmenu items.
https://github.com/gabrielluong/orion.client/commit/dcd68602d30e0b8a9ed572475576065c271ee978
https://orion.eclipse.org/git/reviewRequest.html#https://github.com/gabrielluong/orion.client.git_dcd68602d30e0b8a9ed572475576065c271ee978

I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL

Comment 2 Ken Walker

2013-06-17 14:37:56 EDT

Tested, removes flickering 3rd item

Comment 3 Mark Macdonald

2013-06-17 16:04:33 EDT

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=0b3d818

Comment 4 Mark Macdonald

2013-06-17 16:04:43 EDT