Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 409451

Summary: Browser detection alerts on Chrome for iOS
Product: [ECD] Orion Reporter: Gabriel Luong <gabriel.luong>
Component: ClientAssignee: Gabriel Luong <gabriel.luong>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: mamacdon
Version: 3.0Flags: mamacdon: review+
Target Milestone: 3.0 RC1   
Hardware: PC   
OS: Mac OS X   
Whiteboard:

Description Gabriel Luong CLA 2013-05-30 02:39:41 EDT 
Currently, the browser detection does not check for mobile browsers. It should allow Orion to load on working versions of mobile browsers.
Comment 1 Gabriel Luong CLA 2013-05-30 23:37:53 EDT 
Needs urgent review!

This is the user-agent header sent for chrome on iOS:
Mozilla/5.0 (iPad; CPU OS 6_1 like Mac OS X) AppleWebKit/536.26 (KHTML, like Gecko) CriOS/26.0.1410.53 Mobile/10B141 Safari/8536.25 (7C95DAAF-A20E-4C20-A7F8-77E5BA89DC0B)

CriOS/26.0.1410.53 specifies the chrome version. 

Added a non-capturing match for chrome or crios in the Chrome regexp.
https://github.com/gabrielluong/orion.client/commit/cbba7c5602a3994e4fcc1f41847a0ee4b8da1d5c
https://orion.eclipse.org/git/reviewRequest.html#git://github.com:gabrielluong/orion.client.git_cbba7c5602a3994e4fcc1f41847a0ee4b8da1d5c
Branch Bug409451

I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL
Comment 2 Gabriel Luong CLA 2013-05-31 10:40:11 EDT 
To clarify, the browser detection alerts on chrome on ios. This occurs because the useragent sent from chrome differs from the desktop version. 

In iOS, the chrome version is specify by CriOS/[VERSION NUMBER] whereas it is Chrome/[VERSION NUMBER] for desktops.