Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 408553

Summary:

Theming][Text] background-position and background-repeat are not defined in business/fancy

Product:

[RT] RAP

Reporter:

Ivan Furnadjiev <ivan>

Component:

RWT

Assignee:

Project Inbox <rap-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

2.1

Target Milestone:

2.1 RC2

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Proposed patch	tbuschto: review+

Description Ivan Furnadjiev

2013-05-21 05:57:31 EDT

Running fancy/business theme will warn about missing properties:
Missing value for element: 'Text' property: 'background-position' in theme: 'org.eclipse.rap.design.example.fancy.theme'
Missing value for element: 'Text' property: 'background-repeat' in theme: 'org.eclipse.rap.design.example.fancy.theme'
Missing value for element: 'Text' property: 'background-position' in theme: 'org.eclipse.rap.design.example.business.theme'
Missing value for element: 'Text' property: 'background-repeat' in theme: 'org.eclipse.rap.design.example.business.theme'

Comment 1 Ivan Furnadjiev

2013-05-24 03:47:52 EDT

Created attachment 231436 [details]
Proposed patch

This patch adds defaults for background-position and background-repeat Text properties in business/fancy themes.

Comment 2 Tim Buschtoens

2013-05-24 04:01:45 EDT

Comment on attachment 231436 [details]
Proposed patch

+1
No risks invovled.

Comment 3 Ivan Furnadjiev

2013-05-24 04:12:47 EDT

Applied patch with commit e14c7c4c699a2275999cb559dff7b5a8a9fe678d.