Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 408346

Summary:

Don't use strings from internal NLS files

Product:

[Eclipse Project] Platform

Reporter:

Michael Rennie <Michael_Rennie>

Component:

User Assistance

Assignee:

Michael Rennie <Michael_Rennie>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

curtis.windatt.public, daniel_megert, Lars.Vogel

Version:

4.3

Target Milestone:

4.5 M1

Hardware:

OS:

Windows 7

Whiteboard:

Bug Depends on:

Bug Blocks:

407432

Attachments:

Description	Flags
fix	none

Description Michael Rennie

2013-05-17 10:11:44 EDT

Created attachment 231156 [details]
fix

bug 407431 had to be reverted because UA illegally uses a string from an internal NLS file.

Comment 1 Dani Megert

2014-08-04 03:38:51 EDT

(In reply to Michael Rennie from comment #0)
> Created attachment 231156 [details] [diff]
> fix
> 
Committed that patch with http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=b63f6ef06f975d6b72d6466f604e5c70eac912a6 (including copyright date update to 2014).


> bug 407431 had to be reverted because UA illegally uses a string from an
> internal NLS file.

Bug 407432 that was.

Comment 2 Dani Megert

2014-08-07 04:24:10 EDT

(In reply to Dani Megert from comment #1)
> (In reply to Michael Rennie from comment #0)
> > Created attachment 231156 [details] [diff] [diff]
> > fix
> > 
> Committed that patch with
> http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/
> ?id=b63f6ef06f975d6b72d6466f604e5c70eac912a6 (including copyright date
> update to 2014).

This fix forgot to remove the unused import. Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=b7de173ba67d73b7b0711bf5c8093726263215de