Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 408140

Summary: Test failures with incorrect git configuration
Product: [ECD] Orion Reporter: John Arthorne <john.arthorne>
Component: GitAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ahunter.eclipse, libingw, Szymon.Brandys
Version: unspecified   
Target Milestone: 3.0 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description John Arthorne CLA 2013-05-15 10:52:41 EDT 
There are two Git test failures in I20130514-2230. They look possibly related to bug 408065.

The tests are asserting the git username and email are properly configured on a git repository, and they are not.

1)

org.junit.ComparisonFailure: expected:<[test]> but was:<[e4Build]>
at org.eclipse.orion.server.tests.servlets.git.GitConfigTest.testClonedRepoConfigUsingUserProfile(GitConfigTest.java:72)

------------------------
2)

org.junit.ComparisonFailure: expected:<[test]> but was:<[e4Build]>
at org.eclipse.orion.server.tests.servlets.git.GitConfigTest.testInitializedRepoConfigUsingUserProfile(GitConfigTest.java:134)
Comment 1 libing wang CLA 2013-05-16 10:39:04 EDT 
Talked to Szymon.
Using user profile to test git config is no longer valid.
I commented out those two test cases for now but he will refactor them later and get them back by different test logic.
Comment 3 Anthony Hunter CLA 2014-06-06 14:09:20 EDT 
(In reply to libing wang from comment #2)
> http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/
> ?id=9a1b6ec8bec1182f8a8cf2ecf51474fd7334d60f

Looks like this commit fixed the problem, so marking resolved.