Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 407972

Summary: include new version of p2 in tycho
Product: z_Archived Reporter: Jan Sievers <jan.sievers>
Component: TychoAssignee: Jan Sievers <jan.sievers>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: david_williams, Lars.Vogel, mistria, pascal, pwebster, t-oberlies
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 408691, 408997    
Bug Blocks: 407424    

Description Jan Sievers CLA 2013-05-14 03:37:04 EDT
follow-up on http://dev.eclipse.org/mhonarc/lists/tycho-dev/msg00904.html

@Pascal we need to know

1. list of p2 bugs for which fixes are needed
2. p2 repository from where to consume new version of p2

Note that we have to release before Kepler so p2 must be taken from a Kepler milestone or RC (M7 preferred but not sure if it includes all p2 fixes required)
Comment 1 Tobias Oberlies CLA 2013-05-16 08:27:20 EDT
In case someone still wants to fix something in p2 and test that fix via Tycho, there is documentation how to include locally built p2 bundles into a locally built Tycho: http://wiki.eclipse.org/Developing_Tycho#Building_Tycho_against_a_locally_built_version_of_p2
Comment 2 Tobias Oberlies CLA 2013-05-21 08:21:06 EDT
Resetting target milestone since it remains unclear what the new p2 version would be needed for.
Comment 3 Pascal Rapicault CLA 2013-05-21 08:42:33 EDT
I missed the fact that you were asking for a list of bugs. I thought this was just a place holder bug. So here it is:
- Bug #406902 - Category.xml should allow nested categories 
- Identify product with a property. This is a must to allow the remediation to identify that something is a product and not uninstall it when looking for a solution. There is no bug number for that in p2 because this was done as part of other commits. 

As you see, this is indeed needed.
Comment 4 Mickael Istria CLA 2013-05-21 09:16:57 EDT
For JBoss Tools use-case (but this will for sure be useful to many other projects), we've implemented support of Nested Categories in category.xml. This should apply in Tycho transparently, as it doesn't affect classpath resolution and it is fully implemented internally to the "CategoryXMLAction".

An update of p2 in Tycho would be very nice for our adoption of this improvement.
Comment 5 Jan Sievers CLA 2013-05-21 09:49:38 EDT
(In reply to comment #3)
> I missed the fact that you were asking for a list of bugs. I thought this
> was just a place holder bug. So here it is:
> - Bug #406902 - Category.xml should allow nested categories 

so we will use p2 from the Kepler RC1 repo which is due on May 24 [1]. 

OK?

[1] http://wiki.eclipse.org/Kepler/Simultaneous_Release_Plan#Schedule
Comment 6 Tobias Oberlies CLA 2013-05-21 10:12:18 EDT
RC1 is already out [1]. I'll propose a patch for Tycho's target file.

[1] http://download.eclipse.org/eclipse/downloads/drops4/S-4.3RC1-201305162200/
Comment 7 Tobias Oberlies CLA 2013-05-21 10:15:28 EDT
The new p2 version probably also includes the fix for bug 406942 (according to the bug's fix version).
Comment 8 Tobias Oberlies CLA 2013-05-22 08:55:14 EDT
Kepler RC1 has a regression in the error messages compared to the last version we used: bug 408691

Since "cannot satisfy dependency" errors are pretty common in Tycho, I'd say that this blocks the adoption of RC1 in Tycho.
Comment 9 Tobias Oberlies CLA 2013-05-22 09:54:57 EDT
FYI: I've pushed change that updates the included p2 version to Gerrit [1]. It contains changes to integration tests that we will also need if we should decide to adopt a later p2 version that RC1.

[1] https://git.eclipse.org/r/#/c/13050/
Comment 10 Tobias Oberlies CLA 2013-05-23 12:26:31 EDT
There is progress on bug 408691. This means that we only need to wait for an I-build drop of p2 and then can proceed here.

In case I'm busy, I'm handing it back to the queue.
Comment 11 Jan Sievers CLA 2013-05-24 04:59:38 EDT
http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/commit/?id=eb94a9c052a0bf37b396e66c50a51f9578c19f4f

@Pascal thanks for the quick fix of bug 408691

we can now proceed to stage tycho 0.18.0
Comment 12 Jan Sievers CLA 2013-05-25 03:07:35 EDT
this has caused bug 408997
Comment 13 Jan Sievers CLA 2013-05-27 03:04:16 EDT
to consume the fix for bug 408997, we had to use the pre-RC3 version of p2 from I-build

http://download.eclipse.org/eclipse/downloads/drops4/I20130526-0500/