Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 407820

Summary: Is there a reason we have osgistarter.config.launcher in addition to rcp.config?
Product: [Eclipse Project] Platform Reporter: David Williams <david_williams>
Component: RelengAssignee: David Williams <david_williams>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P4    
Version: 4.3   
Target Milestone: 4.4 M6   
Hardware: PC   
OS: Linux   
Whiteboard:

Description David Williams CLA 2013-05-12 11:37:38 EDT 
These are both "carry overs" from the old eclipsebuilder. 

The are nearly identical ... in fact, would be identical (except for "feature name) except I have been making fixes to rcp.config. 

rcp.config itself is a little mis-named ... "eclipse.config" would be a better name. 

For quick peek, compare: 

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/tree/eclipse.platform.releng.tychoeclipsebuilder/osgistarter.config.launcher

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/tree/eclipse.platform.releng.tychoeclipsebuilder/rcp.config

I'm partially asking since wondering if I should "keep them in synch", If not get rid of starter kit one, or if equinox team is happy with starter kit, I'll just leave osgistarter.config.launcher alone for now (but, want to get rid of it, eventually, if there is no conceptual reason for it).
Comment 1 David Williams CLA 2013-05-12 16:22:15 EDT 
FYI, I did decide to "keep in sync" for now ... that's the build.properties file, and pom.xml. 

The reason is the the Eclipse Icon in the PList issue seems to be fixed for the binary eclipse platform ... but, not the SDK ... so, I just wanted to be sure things were as similar as possible, through out the build. This type of a difference "should not" interact like that ... but ... with Tycho, you never know :) 

So, we'll just consider for future if it should really "have it's own", but my guess is that if/when we make the build more modular, then it should have its own ... so ... just consider this a "note for discussion".
Comment 2 David Williams CLA 2014-03-04 16:27:28 EST 
This was fixed a while back ... we no longer have osgistarter.config in "tychoeclipsebuilder" but do it all from the "product definition".