Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 407802

Summary:

orionode master ignores CTRL on link click

Product:

[ECD] Orion

Reporter:

Adrian Aichner <adrian.aichner>

Component:

Client

Assignee:

Project Inbox <orion.client-inbox>

Status:

RESOLVED WORKSFORME

QA Contact:

Severity:

normal

Priority:

CC:

libingw, mamacdon

Version:

unspecified

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
screenshot	none

Description Adrian Aichner

2013-05-11 15:39:15 EDT

Somewhat unrelated I use setting
General->Navigation->Links: Open in same tab
because that's what I want most of the time.

When I want to open a file or directory in a new tab, however, I hold down the CTRL key while clicking the link in navigator.

This used to work to open files or folders in a new tab in Chrome but now it is no longer honored when clicking on a folder link. The folder opens in the current tab despite my CTRL-click.

Please restore this great feature.

Comment 1 Mark Macdonald

2013-05-15 11:48:27 EDT

I found this frustrating to reproduce, but I finally nailed down some reliable steps (using Chrome):

1. Ensure Settings > General > Links "open in same tab" is selected
2. Go to the Navigator page
3. If you see a yellow selection on any of the rows, use Ctrl+click to unselect everything.
4. Now you should have only a blue focus indicator on one of the rows.
5. Ctrl+Click the folder name that has the blue focus. It opens in a new tab (as expected). However, the blue focus indicator also disappears.
6. Now Ctrl+Click on any of the folder links -- it opens in the same tab, which is wrong.

The key to being in the bad state is when the blue focus indicator disappears. The next time you Ctrl+Click a link, it opens in the same tab.

And this happens on the Orion Java server as well, it's not Node-specific.

Comment 2 Mark Macdonald

2013-05-15 11:51:40 EDT

Created attachment 231016 [details]
screenshot

Here's a screenshot illustrating the steps

Comment 3 Adrian Aichner

2013-05-24 06:25:13 EDT

I am currently using orionode
@commit c83960c30c23ef3eaaf4684cf2d0b12e8842aa28

It's running in following environment:

adrian@tanga:~$ node --version
v0.8.11
adrian@tanga:~$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 13.04
Release:        13.04
Codename:       raring
adrian@tanga:~$

I am testing with browser on Windows XP system:

Crtl+click opens a new tab for me with blue or peach selection indication in

> Mozilla/5.0 (Windows NT 5.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/27.0.1453.94 Safari/537.36
AKA stable Google Chrome

Also works fine in
> [12:22:28.375] "Mozilla/5.0 (Windows NT 5.1; rv:22.0) Gecko/20130513 Firefox/22.0"

Tested in
> Mozilla/5.0 (Windows NT 5.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/29.0.1516.0 Safari/537.36
AKA canary Google Chrome
it does not open a new tab for a directory link.
It does open a new tab for file links though!

Mark, could you also falls victim to some browser issues?

BTW, I have disabled all Google Chrome extensions for my testing above.

Comment 4 Adrian Aichner

2013-05-24 06:38:36 EDT

See also

https://code.google.com/p/chromium/issues/detail?id=236835

and at some more searching for [summary:"ctrl+click"]

https://code.google.com/p/chromium/issues/list?can=2&q=summary%3A%22ctrl%2Bclick%22&colspec=ID+Pri+M+Iteration+ReleaseBlock+Cr+Status+Owner+Summary+OS+Modified&x=m&y=releaseblock&cells=tiles

Comment 5 Adrian Aichner

2014-02-02 08:42:22 EST

This works for me now on local orion node server running HEAD master