Bugzilla – Full Text Bug Listing
| Summary: | Add hover effects for all the buttons in the editor view | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Gabriel Luong <gabriel.luong> |
| Component: | Client | Assignee: | Gabriel Luong <gabriel.luong> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | carolynmacleod4, libingw |
| Version: | 3.0 | Flags: | libingw:
review+
|
| Target Milestone: | 3.0 M2 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
| Bug Depends on: | 408136, 408154 | ||
| Bug Blocks: | 408255 | ||
|
Description
Gabriel Luong
https://github.com/gabrielluong/orion.client/tree/Bug407773 Branch: Bug407773 commit af2b4cd30d3fc948b54fc29c5b731ca8fa56b529 To test: 1. Open a file and examine the following buttons for hover effect: a. Add Content Button b. Setting Button c. Go-up Button d. Outline Button (only appears in js files) e. Setting (Wrench) Button. 2. All buttons should have the same width and height and align correctly with one another. Also, they should appear consistent across Chrome and Firefox. Added button hovers for all the buttons in the mini-nav and setting (wrench) button in the editor view. Regarding the changes in globalCommands.js, I notice layoutRight class would go away after the wrench button was pressed and the dropdown was closed. https://github.com/gabrielluong/orion.client/commit/af2b4cd30d3fc948b54fc29c5b731ca8fa56b529 I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL https://github.com/gabrielluong/orion.client/tree/Bug407773-2 Branch: Bug407773-2 commit 91fdf2c01d408d24d0154da9ae5f546e7f2956d7 Refactored my earlier commit (ignore and don't push commit af2b4cd30d3fc948b54fc29c5b731ca8fa56b529), and added hover to the wrench button. I will look into removing the span within the buttons in Bug408073 https://github.com/gabrielluong/orion.client/commit/91fdf2c01d408d24d0154da9ae5f546e7f2956d7 I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL https://orion.eclipse.org/git/reviewRequest.html#git@github.com:gabrielluong/orion.client.git_91fdf2c01d408d24d0154da9ae5f546e7f2956d7 I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL https://orion.eclipse.org/git/reviewRequest.html#git@github.com:gabrielluong/orion.client.git_2b5d0c6c0ddfd85240887e724a69bef2d628ccfc I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL Looks good and I've tested it. Pushed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=fc3cebdf82415eb53270c48240193f1477b5f4d0 |