Bugzilla – Full Text Bug Listing
| Summary: | Remove support for pre-OSGi 2.0 plug-ins from API Tools | ||
|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Curtis Windatt <curtis.windatt.public> |
| Component: | API Tools | Assignee: | Curtis Windatt <curtis.windatt.public> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | david_williams, tjwatson |
| Version: | 4.3 | ||
| Target Milestone: | 4.4 M1 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| See Also: | https://bugs.eclipse.org/bugs/show_bug.cgi?id=407765 | ||
| Whiteboard: | |||
| Bug Depends on: | 405211, 407312, 407765 | ||
| Bug Blocks: | |||
|
Description
Curtis Windatt
Once I merge the new framework to master the following testcase for api tools will start to fail: ApiToolingApiuseAntTaskTests.testOldStylePlugin If you want to continue to test support for old-style plugins then I suggest you have releng add the org.eclipse.osgi.compatibility.plugins.feature.feature.group IU as an extraIU when running the pde.api.tools.tests similar to how I did for the osgi.tests: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=84fdb7cf2ab7290c2918e80093bd17ce2fd843a0 http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=e4f198b062fda5b335f10aefddce7adfad7b7c9a This will allow you to get green test passes in the build. Otherwise I suggest you disable the test that is failing. (Attempted) fixing by adding these two tests bundles to those that will have the "compatibility bundle" installed as part of their overall setup, in overall test.xml file. Please verify after next 'nightly'. org.eclipse.pde.ui.tests org.eclipse.pde.api.tools.tests http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=d23fddc60b32c7c2455c43d745481f1b43b19e16 (I believe that's all that's needed here, but will let Curtis close, since I'm not sure). Before closing we will have to add a comment to the bug noting that the compatibility fragment must be available. We should also try to direct the user to install the fragment when an old style plug-in is encountered (if PDE UI doesn't do this for us). (In reply to comment #4) > Before closing we will have to add a comment to the bug noting that the > compatibility fragment must be available. We should also try to direct the > user to install the fragment when an old style plug-in is encountered (if > PDE UI doesn't do this for us). Perhaps you'd like to comment in bug 413006 then. Do you think this will be needed frequently enough that it needs its own "category" in our repository? Or, is it enough that its there, and can be part of a more "Extras" category (which, would contain other things as well)? And, FYI, if you wanted the "deluxe" solution, there are p2 functions that can be called from places other than the "Install" menu, where you basically ask people "would you like to install this xyz plugin from abc repository" and has basically same UI as "Install" UI. I've not used it myself ... but, believe Mylyn does for some of its "connectors". (WTP has similar function, but not sure they ever actually moved to the p2 API, since they did the work before the API existed). Marking as fixed for M1. Some additional changes will be made to API tools to support the PDE UI changes in Bug 407765 . |