Bugzilla – Full Text Bug Listing
| Summary: | Comparator log shows many package-info.class files "not in baseline" | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | David Williams <david_williams> |
| Component: | Releng | Assignee: | Platform-Releng-Inbox <platform-releng-inbox> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | daniel_megert, tjwatson |
| Version: | 4.3 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | stalebug | ||
| Bug Depends on: | 407201 | ||
| Bug Blocks: | |||
|
Description
David Williams
David, according to the comparator log if I download the build would you expect me to find the org/osgi/service/event/package-info.class file in the org.eclipse.equinox.app bundle? I am not seeing that. I do not see that in a fresh download of the build or when doing a p2 update (I would expect that for p2 update since it should not pull down the file if the version did not change). (In reply to comment #1) > David, according to the comparator log if I download the build would you > expect me to find the org/osgi/service/event/package-info.class file in the > org.eclipse.equinox.app bundle? I am not seeing that. I do not see that in > a fresh download of the build or when doing a p2 update (I would expect that > for p2 update since it should not pull down the file if the version did not > change). No, sort of the opposite. See the line that says "The main artifact has been replaced with the baseline version." that means that qualifier did not change, so the pre-existing (baseline) version was used instead, even though its different than what was "just built". And then it shows you the difference in case its significant, and you want to touch the bundle and rebuild. This wiki might help explain: http://wiki.eclipse.org/Platform-releng/Platform_Build_Comparator_Logs (In reply to comment #2) > No, sort of the opposite. See the line that says > > "The main artifact has been replaced with the baseline version." > > that means that qualifier did not change, so the pre-existing (baseline) > version was used instead, even though its different than what was "just > built". And then it shows you the difference in case its significant, and > you want to touch the bundle and rebuild. > > This wiki might help explain: > http://wiki.eclipse.org/Platform-releng/Platform_Build_Comparator_Logs Thanks David, I wanted to see one of these bundles that have the extra package-info.class. I have no idea why any of these bundles would all of a sudden get this class injected into them from the build. That just seems wrong. They import the package with the package-info.class, but that should not pull the class into their artifact. (In reply to comment #3) > (In reply to comment #2) > > No, sort of the opposite. See the line that says > > > > "The main artifact has been replaced with the baseline version." > > > > that means that qualifier did not change, so the pre-existing (baseline) > > version was used instead, even though its different than what was "just > > built". And then it shows you the difference in case its significant, and > > you want to touch the bundle and rebuild. > > > > This wiki might help explain: > > http://wiki.eclipse.org/Platform-releng/Platform_Build_Comparator_Logs > > Thanks David, I wanted to see one of these bundles that have the extra > package-info.class. I have no idea why any of these bundles would all of a > sudden get this class injected into them from the build. That just seems > wrong. They import the package with the package-info.class, but that should > not pull the class into their artifact. I think this started when you tried to initially tried to fix Bug 407201 - Source bundles for org.eclipse.osgi.services and -.util broken And, now that you have reverted those changes, it not longer shows up as "not present in baseline" (i.e. is not in "newly built" bundles). BUT ... about 4 bundles have changed, in the mean time, so now the comparator says org/osgi/service/event/package-info.class: present in baseline only So, now those bundles need to be "touched" to NOT include it. Do you want to tell them or should I :) See http://download.eclipse.org/eclipse/downloads/drops4/I20130513-2000/buildlogs/comparatorlogs/buildtimeComparatorUnanticipated.log (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > This wiki might help explain: > > > http://wiki.eclipse.org/Platform-releng/Platform_Build_Comparator_Logs > > > > Thanks David, I wanted to see one of these bundles that have the extra > > package-info.class. > > ... > > Do you want to tell them or should I :) > I've opened bug 407961 for the 4 bundles ... all in platform UI ... so there are 4 you can "see" in the distribution. eclipse.platform.ui/bundles/org.eclipse.e4.ui.workbench eclipse.platform.ui/bundles/org.eclipse.e4.ui.workbench.swt eclipse.platform.ui/bundles/org.eclipse.e4.ui.workbench.renderers.swt eclipse.platform.ui/bundles/org.eclipse.ui.workbench (In reply to comment #5) > > Do you want to tell them or should I :) > > > > I've opened bug 407961 for the 4 bundles ... all in platform UI ... so there > are 4 you can "see" in the distribution. > Thanks David, I was about to open a bug but saw you already did. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |