Bug 407351

Description Charles Chen 2013-05-06 22:26:03 EDT

I'm using tabbed properties view and run into this problem: the property view sections are not layout correctly based on afterSection specification when the extension point definition scattered in different bundles. the extension point i use is org.eclipse.ui.views.properties.tabbed.propertySections.

After looking into class TabDescriptor, here is my simple understanding: the behavior of the sorter method is depending on the sequence of reading the section configuration.
assuming that there is an existing section C which is after section A, you want to insert section B:
  1. if read section C's configuration first, the result will be B->C-A, which is wrong;
  2. if read section A's configuration first, the result will be A->B->C, which is expected;

TabDescriptor.java
package org.eclipse.ui.internal.views.properties.tabbed.view;
...
/**
 * Represents the default implementation of a tab descriptor on the tabbed
 * property tabs extensions.
 * 
 * @author Anthony Hunter
 */
public class TabDescriptor extends AbstractTabDescriptor {

	...

	/**
	 * Insert the section descriptor into the section descriptor list.
	 * 
	 * @param target
	 *            the section descriptor to insert.
	 * @return <code>true</code> if the target descriptor was added to the
	 *         descriptors list.
	 */
	private boolean insertSectionDescriptor(ISectionDescriptor target) {
		if (target.getAfterSection().equals(TOP)) {
			getSectionDescriptors().add(0, target);
			return true;
		}
		for (int i = 0; i < getSectionDescriptors().size(); i++) {
			ISectionDescriptor descriptor = (ISectionDescriptor) getSectionDescriptors()
					.get(i);
			if (target.getAfterSection().equals(descriptor.getId())) {
				getSectionDescriptors().add(i + 1, target);
				return true;
			} else if (descriptor.getAfterSection().equals(target.getId())) {
				getSectionDescriptors().add(i, target);
				return true;
			}
		}
		return false;
	}

	...
}

Could anyone help on this issue ASAP? A consistent properties view layout is important for us to avoid confusing customers.