Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 406716

Summary: [sidebar] Command hotkeys do not work in sidebar navigator
Product: [ECD] Orion Reporter: Mark Macdonald <mamacdon>
Component: ClientAssignee: Mark Macdonald <mamacdon>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 3.0   
Target Milestone: 3.0 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Mark Macdonald CLA 2013-04-26 20:05:17 EDT
The expected hotkeys (F2 to rename, DEL to delete, Alt+UpArrow to Go Up, etc) aren't working in the sidebar navigator. 

The keybindings are registered on the commands as usual, but they do not work.
Comment 1 Mark Macdonald CLA 2013-05-23 15:51:12 EDT
The problem was that the sidebar registers its bindings (using CommandRegistry#registerCommandContribution) before the actual commands that it wants to bind are in the registry (i.e. prior to #addCommand). This causes the registry to never hook up the binding to the command. 

I fixed the CommandRegistry to remember unresolved bindings, and resolve them as commands are added:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=93c4d9f

In addition to the hotkeys mentioned in Comment 0, Ctrl+C and Ctrl+V are now supported:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=c02463d