Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 406469

Summary: [1.8][dom ast] ASTRewrite support for PackageQualifiedType
Product: [Eclipse Project] JDT Reporter: Markus Keller <markus.kell.r>
Component: CoreAssignee: Manoj N Palat <manoj.palat>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: jarthana, manoj.palat, srikanth_sankaran
Version: 4.3Flags: markus.kell.r: review+
Target Milestone: BETA J8   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 404489    
Bug Blocks: 407056, 407364    
Attachments:
Description Flags
Proposed Patch - WIP
none
Proposed Patch none

Description Markus Keller CLA 2013-04-24 13:10:32 EDT 
Implement ASTRewrite for PackageQualifiedType. Duplicate and adapt the visit(QualifiedType) methods of ASTRewriteFlattener and ASTRewriteAnalyzer.
Comment 1 Manoj N Palat CLA 2013-05-03 00:46:08 EDT 
Created attachment 230441 [details]
Proposed Patch - WIP

Manju: You can use this wip patch for UI work (bug 407056) until the final patch is uploaded. This patch is Work-In-Progress only because I would want to add some more tests. Implementation-wise its a direct adaptation of QT and hence complete (without tests).
Comment 2 Manoj N Palat CLA 2013-05-03 02:56:16 EDT 
Created attachment 230443 [details]
Proposed Patch
Comment 3 Markus Keller CLA 2013-05-03 12:50:55 EDT 
Looks pretty good.

Changed @since in ASTRewriteFlattener#visit(PackageQualifiedType) to
"3.9 BETA_JAVA8", removed the unused @A and @B in the test, and released as http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=04abb6d1e9cce4ccf64496ee5f7d45399d283bd2