Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 406389

Summary: full repository fails to aggregate
Product: [Eclipse Project] Platform Reporter: David Williams <david_williams>
Component: RelengAssignee: David Williams <david_williams>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 4.3   
Target Milestone: 4.3 M7   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
log showing errors
none
Just for those interested, here is the full IU that'll removed. none

Description David Williams CLA 2013-04-23 23:19:29 EDT 
Created attachment 230056 [details]
log showing errors

I was using 
http://download.eclipse.org/eclipse/updates/4.3-I-builds/I20130423-0800

And using b3 aggregator to see if whole repository would "pass" b3 aggregator build. It didn't. Saying not all artifacts could be mirrored. 

I'll attach the end of the full log, but the first error message, that I think gives a clue to the problem is as follows: 

!ENTRY org.eclipse.b3.util 4 -364274674 2013-04-23 22:57:24.170
!MESSAGE Artifact org.eclipse.b3.p2.impl.ArtifactKeyImpl@97dde2e (classifier: org.eclipse.update.feature, id: org.eclipse.rcp.configuration, version: 1.0.0.v20130412-0532) could not be found in the artifact repository (http://download.eclipse.org/eclipse/updates/4.3-I-builds/I20130423-0800)

I think this is saying that the org.eclipse.update.feature still "includes" the 
org.eclipse.rcp.configuration feature ... even though I removed org.eclipse.rcp.configuration as a feature, and allow just its p2 metadata to be used ... as it was in PDE build. No idea why org.eclipse.update.feature would include it, but that's that I'll check first. 

I should note, this is not (necessarily) related to the b3 aggregation we do to the "common repo" ... I've not tried that yet, but that's always been a subset of everything we build.
Comment 1 David Williams CLA 2013-04-23 23:57:30 EDT 
There's no other feature that includes it, but is in the repo. I guess we do make it, so we can include as "extraRequirement" for products, but nothing literally includes it. So ... I think the solution is just to remove it from repo, post-build, as we do other of the "fake features". 

This is our current list of things we remove from repo: 

<p2.remove.iu>
    <repository location="file://${siteDirOnBuildMachine}" />
    <iu id="org.aspectj.weaver" />
    <iu id="master.feature.group" />
    <iu id="master-ecf.feature.group" />
    <iu id="master-jetty.feature.group" />
    <iu id="master-equinox-weaving.feature.group" />
    <iu id="master-equinox.feature.group" />
    <iu id="eclipse-junit-tests" />
    <iu query="property[@name='org.eclipse.equinox.p2.type.category']" />

</p2.remove.iu>

So, I propose we "fix" this by also adding 

org.eclipse.rcp.configuration.feature.group
Comment 2 David Williams CLA 2013-04-24 00:09:59 EDT 
Created attachment 230057 [details]
Just for those interested, here is the full IU that'll removed.

Note, some of the "old stuff" like carbon ... removed via some other recent bug.
Comment 4 David Williams CLA 2013-05-30 16:44:45 EDT 
mass change to 'verified', as these bugs are either routine or obviously fixed build breaks.