Bugzilla – Full Text Bug Listing
| Summary: | TrimStack does not use localized label for minimized Parts in TrimStack | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Sebastian Weis <sebastian.weis> |
| Component: | UI | Assignee: | Eric Moffatt <emoffatt> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | emoffatt, pwebster |
| Version: | 4.3 | Keywords: | helpwanted |
| Target Milestone: | 4.3 M7 | ||
| Hardware: | PC | ||
| OS: | All | ||
| Whiteboard: | |||
Sebastian, good pickup, thanks ! http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1f4db9d6fcb425dc2ab861b75fbdb78fb246d78f Test this on your app once M7 goes out and let me know how it goes... Hello Eric, thanks for the quick fix. I will let you know if this solves the problem. Paul, this is almost certainly fixed (at least the code change to use 'getLocalizedLabel' is in, I haven't marked it verified since I'm not set up to test it... Verified (visually) in 4.3.0.I20130516-2200. Sebastian, please test this on RC1 and comment whether it fixes your issue or not... Hello Eric, I checked with 4.3RC1-201305162200 and it now works as expected. Thanks again for the quick fix. |
Version: Kepler Release Build id: 20130320-2352 When a Part(Stack) is minimized, the ToolTip set is not the localized value of the Part's label but the actual String (e.g. "%key" instead of "value"). I think this is caused in org.eclipse.e4.ui.workbench.addons.minmax.TrimStack updateTrimStackItems() { ... newItem.setToolTipText(getLabelText(labelElement)); } If in getLabelText(MUILabel label) getOverrideTitleToolTip((MUIElement) label) returns null the Label is set to String string = label.getLabel(); I think this should instead be String string = label.getLocalizedLabel;