Bugzilla – Full Text Bug Listing
| Summary: | Can't submit review | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Miles Parker <milesparker> |
| Component: | Mylyn | Assignee: | Mylyn Inbox <mylyn-inbox> |
| Status: | RESOLVED DUPLICATE | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | Macintosh | ||
| OS: | Mac OS X | ||
| Whiteboard: | |||
|
Description
Miles Parker
That could be expected. The web UI shows the Publish and Submit button even when not all requirements are satisfied. The Submit fails in a error if there are still approvals missing. (In reply to comment #1) > That could be expected. The web UI shows the Publish and Submit button even when > not all requirements are satisfied. The Submit fails in a error if there are > still approvals missing. In this case I was able to then submit the review from the Web UI. But now that I think of it, I'm not sure I didn't end up changing some of the dialog buttons to +'s. But I don't want to pollute any of the reviews repos by trying it out now. But in any case, I see what you're saying -- given that a committer would often click +2 or IP +1 or whatever as part of the submission, perhaps that's why canSubmit is false. I'm not sure if/how we should change this workflow short of waiting for a resolution to bug 396315 or at least bug 357323. It seems best to me to implement bug 357323. It sounds like the Gerrit connector is working as expected. Based on Steffen's comment, I think this is essentially a dup of bug 357323 *** This bug has been marked as a duplicate of bug 357323 *** |