Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 405808

Summary: [CBI] Platform binary distribution (still) contains pack.gz files
Product: [Eclipse Project] Platform Reporter: David Williams <david_williams>
Component: RelengAssignee: David Williams <david_williams>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: pwebster
Version: 4.2.1   
Target Milestone: 4.3 RC1   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
patch to put p2.remove in ant script that creates this repo none

Description David Williams CLA 2013-04-16 13:18:39 EDT
This makes it quite a bit larger than it was for PDE builds. 

Such as 148 MB instead of 100 MB. 

This is similar to the "sliced repos" for JDT, PDE, etc. (bug 403805) so solution is probably similar.
Comment 1 David Williams CLA 2013-04-16 13:32:37 EDT
Just to document details, (fixing this will be a bit trial and error), there are three places in our aggregator that specify 
<includePackedArtifacts>
Two in profiles in eclipse parent: eclipse-pack and eclipse-sign profile. One of those was false and one of those was true. I think they both need to to be false. The profile eclipse-pack is still important, since that is also what does the "pre-conditioning", apparently. 

Then there's the one in in 
eclipse.platform.repository
that says "true" as is intended, so the final, main repo will be ready for "web deployment".
Comment 2 David Williams CLA 2013-04-16 13:36:54 EDT
I'll try this fix, (changing the other in eclipse-parent to false)

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=6ad8c84ff3002909173ef25719b96decca053b53

And see if that fixes the "binary platform distribution" case ... without effecting anything else. 

This will take an I build to test. I can likely run a build machine only test build to get a sense if its working.
Comment 3 David Williams CLA 2013-05-02 18:23:14 EDT
Not fixed in M7 ... will need to investigate. 
I noticed issue comparing "the last PDE build" (where it is only 100 MB) with the one from M7 (where it is nearly 150M)
Comment 4 David Williams CLA 2013-05-05 17:40:14 EDT
http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=cee3342e120862eb769a845c0fd423149c3851f0

I'll attempt to fix by adding 

<includePackedArtifacts>false</includePackedArtifacts>
to all the 
target-platform-configuration

for "products" in tychoeclipse builder. 

Except for those where it is not a problem. Not sure why some seem to inherit right value from eclipse parent, and other do not ... but ... even if that's it some subtle bug in Tycho, at this point best to fix just by setting explicitly where needed.
Comment 5 David Williams CLA 2013-05-06 00:01:39 EDT
That didn't fix it, either. But, see 407130 for some info that might explain why
Comment 6 David Williams CLA 2013-05-06 00:13:57 EDT
(In reply to comment #5)
> That didn't fix it, either. But, see 407130 for some info that might explain
> why

That is, we currently create the repos "slice" from the main, final, repo, but I can't help wonder why we don't create (copy) the one that's already created at 

/opt/public/eclipse/builds/4I/gitCache/eclipse.platform.releng.aggregator/eclipse.platform.releng.tychoeclipsebuilder/platform/target
Comment 7 David Williams CLA 2013-05-06 16:09:22 EDT
Created attachment 230547 [details]
patch to put p2.remove in ant script that creates this repo

This patch contains 2 fixes. One for this bug, one for bug 407314.
Comment 8 David Williams CLA 2013-05-06 16:09:58 EDT
Paul, any comments?
Comment 9 David Williams CLA 2013-05-06 16:30:59 EDT
http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=721bfe0dbf0cb0f3ddd48283cd170d9cdc2800f8

I think this fix is pretty straightforward, (I forgot one p2.remove, in patch). 

But this commit is only for this bug, not bug 407314.
Comment 10 David Williams CLA 2013-05-07 18:14:06 EDT
Verified in build I20130507-1100 ... back down to 100 Meg.