Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 405273

Summary: UI does not detect invalid models
Product: [Modeling] EMFCompare Reporter: William Piers <william.piers>
Component: UIAssignee: EMF Compare <emf.compare-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: axel.richard, laurent.goubet, mikael.barbero
Version: 2.1.0Keywords: helpwanted
Target Milestone: Luna M3   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
the left model
none
the right model none

Description William Piers CLA 2013-04-09 08:39:13 EDT
Created attachment 229498 [details]
the left model

The two models attached are dynamic instances of the Nodes test metamodel.
As the .ecore file is not aside them they can't be opened.
But when comparing each other with EMF compare, it simply detects "no differences". It should detect that the models are invalid instead.
Comment 1 William Piers CLA 2013-04-09 08:39:36 EDT
Created attachment 229499 [details]
the right model
Comment 2 Laurent Goubet CLA 2013-07-22 05:39:11 EDT
It seems like this would only require us to display an error message in the structure pane, allowing users to know that something isn't right with the "model" comparison, and that he should instead switch to "textual".
Comment 3 Axel RICHARD CLA 2013-10-09 06:09:43 EDT
Proposal has been committed: https://git.eclipse.org/r/#/c/17201/

A message is logged, a pop-up is display with the error and the editor is closed.
Comment 4 Mikaƫl Barbero CLA 2013-10-21 04:51:18 EDT
Fixed in 792e66bc29b83d8e2510dfd5c54ccde91892020f