Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 405174

Summary:	CSS is not being concatenated
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Client	Assignee:	Mark Macdonald <mamacdon>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ken_walker, simon_kaegi
Version:	3.0
Target Milestone:	3.0 RC1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mark Macdonald

2013-04-08 10:56:23 EDT

Upgrading to RequireJS 2 has resurrected bug 401340. Page CSS is not being concatenated:

1. Launch a recent Orion server
2. Go to [orionServerURL]/navigate/table.css. 
3. This file should be a concatenation of the 4 stylesheets but it is not.

Comment 1 Mark Macdonald

2013-04-08 10:59:51 EDT

In the build log I see this:
> [java] Error: Missing either a "name", "include" or "modules" option

The command we (used to) use to concatenate the CSS files is:

>      [java] Running in same VM Executing 
> 'org.mozilla.javascript.tools.shell.Main' with arguments:
> '/shared/eclipse/e4/orion/requirejs/dist/r.js'
> '-o'
> '/shared/eclipse/e4/orion/support/org.eclipse.orion.releng/builder/scripts
> /orion.build.js'
> 'optimize=none'
> 'appDir=/shared/eclipse/e4/orion/I201304072230/optimization'
> 'dir=/shared/eclipse/e4/orion/I201304072230/optimization'

Comment 2 Mark Macdonald

2013-06-03 10:45:35 EDT

This is slowing down our page loads by 150ms according to Simon. Time to fix it

Comment 3 Mark Macdonald

2013-06-03 12:31:10 EDT

Fixed in the 'I201306031116' build.

http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=5a9f995