Bugzilla – Full Text Bug Listing
| Summary: | remove bundles that are not required when running on 1.6 or later | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Steffen Pingel <steffen.pingel> |
| Component: | Mylyn | Assignee: | Steffen Pingel <steffen.pingel> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | krzysztof.daniel, shawn.minto |
| Version: | unspecified | ||
| Target Milestone: | 3.9 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Bug Depends on: | 383907 | ||
| Bug Blocks: | |||
|
Description
Steffen Pingel
Krzysztof, anything other bundles that we should consider? javax.activation Affected files: ./org.eclipse.mylyn.commons/org.eclipse.mylyn.commons.soap/META-INF/MANIFEST.MF ./org.eclipse.mylyn.builds/org.eclipse.mylyn.hudson.core/META-INF/MANIFEST.MF ./org.eclipse.mylyn.commons/org.eclipse.mylyn.commons.sdk-feature/feature.xml ./org.eclipse.mylyn.builds/org.eclipse.mylyn.hudson-feature/feature.xml ./org.eclipse.mylyn.builds/org.eclipse.mylyn.builds.sdk-feature/feature.xml ./org.eclipse.mylyn.tasks/org.eclipse.mylyn.bugzilla-feature/feature.xml Preparing a patch now. https://git.eclipse.org/r/#/c/11808/ https://git.eclipse.org/r/#/c/11809/ https://git.eclipse.org/r/#/c/11811/ Those three patches remove aforementioned bundles from the mylyn, but not from it's deps: * javax.activation is required by: com.sun.xml.bind, javax.mail, javax.xml.soap, org.apache.axis * javax.xml.soap is required by org.apache.axis, javax.xml.rpc * javax.xml.stream is required by com.sun.xml.bind (In reply to comment #5) > Those three patches remove aforementioned bundles from the mylyn, but not from > it's deps: > * javax.activation is required by: com.sun.xml.bind, We should be able to drop com.sun.xml.bind since it was only needed for 1.5. > javax.mail, javax.xml.soap, org.apache.axis These are only required for SOAP which none of the built in Mylyn connectors require. Would it make a difference to split all SOAP dependencies into a separate feature? We would end up with: pre. org.eclipse.mylyn.commons.soap_feature: javax.activation javax.xml.soap javax.wsdl org.apache.axis We would drop these bundles (still needs verification): pre. com.sun.xml.bind javax.xml (only present in the build target) javax.xml.bind javax.xml.stream Sounds good! Here are the reviews: Mylyn Commons: https://git.eclipse.org/r/#/c/12115/ Mylyn Tasks: https://git.eclipse.org/r/#/c/12113/ Mylyn Builds: https://git.eclipse.org/r/#/c/12114/ Target platform update: https://git.eclipse.org/r/#/c/12117/ I verified manually that installing still worked without having the bundles included in the SOAP feature on the update site. I pushed another review to add the SOAP feature to the site for integrators to consume (but none of the Mylyn features depend on it): https://git.eclipse.org/r/#/c/12167/. The latest weekly build now has the Axis dependencies split out into a separate feature. Krzysztof, please let me know if there is anything we missed. While building recent version of mylyn for Fedora I've found javax.xml in http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.tasks.git/tree/org.eclipse.mylyn.sdk-feature/feature.xml Yes, sorry, we had to put that back, since we recently added Apache Xerces 2.9 as a dependency. The Xerces bundle requires javax.xml 1.3.4 to be present. |