Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 404592

Summary: Set up client bundles for JSDT development
Product: [ECD] Orion Reporter: Mark Macdonald <mamacdon>
Component: ClientAssignee: Project Inbox <orion.client-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: thatnitind
Version: 3.0   
Target Milestone: 3.0 M1   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
patch to narrow the source folders to the "web" folders none

Description Mark Macdonald CLA 2013-03-28 15:47:59 EDT 
It was pointed out on the #eclipse-orion IRC channel that our current client-side bundles are not correctly set up to be edited by the Eclipse JavaScript development tools (JSDT).

Things we need to fix are:

- Source folders for JS should be set to each project's web/ folder, not the project root
- All projects should have the JavaScript project nature (currently some lack it)
- Project references should be set to express dependencies:
   org.eclipse.orion.client.ui     -> org.eclipse.orion.client.core
   org.eclipse.orion.client.editor -> org.eclipse.orion.client.core
   org.eclipse.orion.client.git    -> org.eclipse.orion.client.ui
   org.eclipse.orion.client.users  -> org.eclipse.orion.client.ui


JSDT is not our typical development environment, but some people may use Orion in JSDT, so we should fix our project setup to allow this.
Comment 1 Mark Macdonald CLA 2013-04-01 15:54:07 EDT 
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=24b6d5f772434ed6d8aed666

OK. The JS source paths are set. The JS nature is assigned to all projects. Project dependencies are set up. I added Source Path exclusions for various libraries in our projects, which we don't want to validate (gcli, persona, jsdiff, requirejs, etc). Also added exclusions for certain Orion source files that the JSDT validator barfs on (eg. gitStatusExplorer.js, which triggers JSDT bug 357353).
Comment 2 Nitin Dahyabhai CLA 2013-04-01 16:47:07 EDT 
Created attachment 229218 [details]
patch to narrow the source folders to the "web" folders

Reopening (I think) for one more patch which sets the "web" folders as the source folders, as they're also the AMD module paths in their projects.
Comment 3 Mark Macdonald CLA 2013-04-01 17:13:38 EDT 
Thanks, Nitin. Can you please confirm ownership of the code in your patch by posting a statement like this:

> I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EDL+EPL

Then I'll release the patch.
Comment 4 Nitin Dahyabhai CLA 2013-04-01 20:05:34 EDT 
(In reply to comment #3)
> Thanks, Nitin. Can you please confirm ownership of the code in your patch by
> posting a statement like this:
> 
> > I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EDL+EPL
> 
> Then I'll release the patch.


Sure thing.

"I, Nitin Dahyabhai, assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EDL+EPL."