Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 404403

Summary: Difficult to determine how to delete site
Product: [ECD] Orion Reporter: Carolyn MacLeod <carolynmacleod4>
Component: ClientAssignee: Curtis Windatt <curtis.windatt.public>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: curtis.windatt.public, mamacdon, Michael_Rennie
Version: 3.0   
Target Milestone: 5.0 M1   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on:    
Bug Blocks: 421368    

Description Carolyn MacLeod CLA 2013-03-26 15:51:40 EDT 
I had an old site I wanted to delete (it was the only one I had).
I had to ask someone how to delete it.
If you only have one site, it is not apparent that it is in a list.

Not sure the best way to fix this. Maybe the Delete button should be visible if there is only one site, even if the site is not selected?
Comment 1 Mark Macdonald CLA 2013-03-28 13:35:47 EDT 
Perhaps we can select the first site in the list by default (or when only one site exists). Then the Delete button would be visible.
Comment 2 Carolyn MacLeod CLA 2013-03-28 14:42:16 EDT 
Sounds good. Slight preference for always selecting the first, even if there's more than one.
Comment 3 Michael Rennie CLA 2013-11-01 10:23:50 EDT 
(In reply to Carolyn MacLeod from comment #2)
> Sounds good. Slight preference for always selecting the first, even if
> there's more than one.

Or perhaps we could enhance the list like the Git repositories page - where all of the buttons appear on the RHS for each site. That would solve the discoverability issues and make it immediately apparent it is a list as well (I also had to ask someone how to delete a site).
Comment 4 Curtis Windatt CLA 2013-11-26 17:47:14 EST 
https://git.eclipse.org/r/18940
Refreshes the look and feel of the sites explorer.

The page no longer allows selection and uses a section layout matching the git explorer pages.  If multiple site configurations exist for a site services, they are put into a tree (I'm not sure how to do this normally so I tested by changing the if check on line 120).

I also attempted to fix Bug 421368, where the page looks odd if you delete all the sites.  This was also difficult to test as deleting all the sites results in the self hosting being ended.  The code for it is added at line 142.

I suspect that deleting your last site will not put up the no sites entry. I will look into moving that code to updateRows.  Also, just saw that a changed ID results in an error when rendering the commands, I will fix it and update the patch set.
Comment 5 Curtis Windatt CLA 2013-11-27 13:47:24 EST 
(In reply to Curtis Windatt from comment #4)
> I suspect that deleting your last site will not put up the no sites entry. I
> will look into moving that code to updateRows.  Also, just saw that a
> changed ID results in an error when rendering the commands, I will fix it
> and update the patch set.

The patch set has been updated.  When you delete the last site, the info box will show with the create command embedded in it.  I believe this is ready to be reviewed.