Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 404082

Summary: [dstore] race condition on finish, removing senders
Product: [Tools] Target Management Reporter: David McKnight <dmcknigh>
Component: RSEAssignee: David McKnight <dmcknigh>
Status: RESOLVED FIXED QA Contact: David Dykstal <ddykstal.eclipse>
Severity: normal    
Priority: P3 CC: cbmcgee, dmcknigh
Version: 3.4.2   
Target Milestone: 3.5 M6   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 404085    
Attachments:
Description Flags
patch to not lock in removeSenders
none
updated patch none

Description David McKnight CLA 2013-03-21 16:57:13 EDT 
If you connect to a server, do no operations and then disconnect, the server may not complete due to a deadlock.  This occurs because the completing code, which removes senders from the ServerUpdateHandler tries to send data to the client while another thread that blocks that is in-turn blocked by the senders lock.
Comment 1 David McKnight CLA 2013-03-21 17:04:57 EDT 
Created attachment 228888 [details]
patch to not lock in removeSenders
Comment 2 David McKnight CLA 2013-03-21 17:13:09 EDT 
I've committed the change.
Comment 3 David McKnight CLA 2013-03-21 17:40:41 EDT 
The push failed so I'm reopening this.  My egit environment frequently fails on push so I'll probably have to recreate the workspace before I'm able to get this in.
Comment 4 David McKnight CLA 2013-03-22 07:54:52 EDT 
*** Bug 404100 has been marked as a duplicate of this bug. ***
Comment 5 David McKnight CLA 2013-03-22 08:56:10 EDT 
I managed to get git push to work in a new workspace this morning.
Comment 6 David McKnight CLA 2014-07-14 11:35:17 EDT 
Created attachment 245038 [details]
updated patch