Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 404016

Summary:	Regression to 4.x: Workbench window as runnable context does not work/block
Product:	[Eclipse Project] Platform	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	Eric Moffatt <emoffatt>
Status:	VERIFIED FIXED	QA Contact:
Severity:	critical
Priority:	P3	CC:	emoffatt, jflicke, markus.kell.r, mauromol, Michael_Rennie, pwebster, steffen.pingel
Version:	4.2.2	Flags:	pwebster: review+
Target Milestone:	4.3 RC1
Hardware:	All
OS:	All
Whiteboard:

Description Dani Megert

2013-03-21 08:21:58 EDT

4.2.

We call IRunnableContext.run(true, true, op) where the context is the workbench window. In contrast to 3.x this does not block the UI and allows the user to continue to mess around with the UI, e.g. typing text.

BTW ww.run(...) has this suspicious comment:
// Temporary Hack for bug 330106, remove when bug 334093 is fixed


Test Case:
1. start fresh workspace
2. paste: "class A extends Object {}" into Package Explorer
3. select "Object" in the editor
4. press Ctrl+T
==> type some stuff. In 3.x this was not possible, while in 4.x it just changes the editor's text.

Comment 1 Dani Megert

2013-03-21 08:22:53 EDT

And there's also no busy cursor (spinning wheel).

Comment 2 Dani Megert

2013-03-21 08:31:02 EDT

Same on Linux. For fun, one can e.g. close the editor to get some NPEs.

Comment 3 Paul Webster

2013-04-29 13:59:02 EDT

Cut at disabling controls during the run(*) operation.

Eric, can you please review?

https://git.eclipse.org/r/12361

PW

Comment 4 Eric Moffatt

2013-05-07 15:23:22 EDT

I've pushed a different approach to Gerrit, could you have a look ?

Comment 5 Eric Moffatt

2013-05-09 15:05:50 EDT

Amended the previous commit to add code to disable/enable the BindingService...

Comment 6 Paul Webster

2013-05-13 09:04:12 EDT

We just need Dani to re-review (or unreview), Gerrit won't submit it if there's a -2 on it.

PW

Comment 7 Dani Megert

2013-05-13 11:00:12 EDT

(In reply to comment #6)
> We just need Dani to re-review (or unreview), Gerrit won't submit it if
> there's a -2 on it.
> 
> PW

Will do today or tomorrow.

Comment 8 Eric Moffatt

2013-05-14 10:22:17 EDT

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=96b7c38e40aff3d1e3ea3fa3941a159d0ceea206

Committed the last change set...

Comment 9 Paul Webster

2013-05-17 10:35:44 EDT

In 4.3.0.I20130516-2200

Verified usecase in comment #0

PW

Comment 10 Dani Megert

2013-05-28 08:44:12 EDT

(In reply to comment #8)
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?id=96b7c38e40aff3d1e3ea3fa3941a159d0ceea206
> 
> Committed the last change set...

This causes a bad regression, see bug 409274.