Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 403810

Summary: [1.8] @since tags need adjusting.
Product: [Eclipse Project] JDT Reporter: Srikanth Sankaran <srikanth_sankaran>
Component: CoreAssignee: shankha banerjee <shankhba>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: jarthana, shankhba, srikanth_sankaran, stephan.herrmann
Version: 4.3Flags: jarthana: review+
Target Milestone: BETA J8   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on:    
Bug Blocks: 380190    
Attachments:
Description Flags
New Patch
none
New Patch
none
New Patch shankhba: review?

Description Srikanth Sankaran CLA 2013-03-19 12:38:12 EDT 
BETA_JAVA8:

At the moment, we have been tagging Java 8 API items (mostly IProblems)
with "@since 3.9"

This needs to be adjusted to be "@since 3.9 BETA_JAVA8"

We don't want to use 3.9.1 since we want to be able to distinguish between
what gets added in 3.9.1 in normal course and what got expressly added for
Java 8 support.
Comment 1 Srikanth Sankaran CLA 2013-03-19 12:38:52 EDT 
Shankha, Thanks for following up.
Comment 2 Stephan Herrmann CLA 2013-03-31 14:25:19 EDT 
As I had to make an addition to IProblem I added the BETA_JAVA8 token to
all constants in this file which are not also in master.
See commit 86ee968d8acf90a0a75c72085f72a3416b02186d (bug 404649).
Comment 3 shankha banerjee CLA 2013-04-24 04:52:40 EDT 
Created attachment 230064 [details]
New Patch

Made changes to replace the tag 3.9 with 3. BETA_JAVA8. 
Have updated the copyright information for files where I need to. 

Please review. 

Thanks.
Comment 4 shankha banerjee CLA 2013-04-24 05:08:29 EDT 
Comment on attachment 230064 [details]
New Patch

I had replaced all the 3.9 tags. I should have replaced only the ones for BETA_JAVA8. I will correct the patch a upload a new one.
Comment 5 shankha banerjee CLA 2013-04-24 08:41:48 EDT 
Created attachment 230072 [details]
New Patch

New patch takes care to not disturb the tags fields relevant to variables on the master.

Please review. 

Thanks.
Comment 6 shankha banerjee CLA 2013-04-25 03:02:09 EDT 
Created attachment 230103 [details]
New Patch

Patch works with EGit. Have verified the patch can be applied on fresh BETA_JAVA8 branch without any issues through EGIT. 

Thanks
Comment 7 Jay Arthanareeswaran CLA 2013-04-25 04:28:34 EDT 
(In reply to comment #6)
> Created attachment 230103 [details]
> New Patch

Thanks Shankha, I have released the changes excluding CompletionContext - the API TL_CONSTRUCTOR_START was added as part of Kepler work.

http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?h=BETA_JAVA8&id=a9a2f610dbfd1c80acbe2670e60eb850641763f6