Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 403256

Summary:	[CBI] Source bundles containing libraries do not have correct folder structure
Product:	[Eclipse Project] Platform	Reporter:	Thanh Ha <thanh.ha>
Component:	Releng	Assignee:	Thanh Ha <thanh.ha>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	curtis.windatt.public, daniel_megert, david_williams, jan.sievers, thanh.ha
Version:	4.2.2
Target Milestone:	3.8.2+
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:	400740, 400956
Bug Blocks:	403098

Description Thanh Ha

2013-03-13 15:10:23 EDT

+++ This bug was initially created as a clone of Bug #400740 +++

I20130212-0811

org.eclipse.jdt.debug is split into two libraries jdi.jar and jdimodel.jar.  The source for the libraries is stored in two separate source folders.  When building the source bundle, the source for each librray should be placed into a separate folder (jdisrc and jdimodelsrc).

In the CBI based build, the source for both libraries is being placed at the root of the source bundle.

This breaks PDE plug-in import because we need to create separate source folders in the created project based on the libraries.  With the source at the root of the jar we have no idea what files are actually source for the bundle and what library they belong to.  Source attachments still work because JDT will fall back at looking at the root of the jar, but this will come with some performance penalty.

For another example see org.eclipse.pde.build.source

Comment 1 Thanh Ha

2013-03-13 15:11:42 EDT

Commit to be cherry-picked:
http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=96bb6ad3a50d9998eff6c3246cfcdcf6c8c68788

Comment 2 Thanh Ha

2013-03-15 09:17:16 EDT

This should be cherry-picked into both 3.8 and 4.2 branches.

Comment 3 Thanh Ha

2013-03-15 13:40:46 EDT

Released into 3.8 and 4.2.

R3_8_maintenance:
http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?h=R3_8_maintenance&id=3664ac39992a2ac282244690ac1c97c29b72a1fe

R4_2_maintenance:
http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?h=R4_2_maintenance&id=4addc265f84d92651522c9b878e275a6c3d7805f

Comment 4 Thanh Ha

2013-03-15 13:41:11 EDT