Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 403096

Summary:	problem pushing to git in master
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Git	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	ken_walker, malgorzata.tomczyk, Szymon.Brandys
Version:	unspecified
Target Milestone:	3.0 M1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2013-03-12 13:47:33 EDT

I am unable to push a commit from the code in master, and it works in the deployed build.

This could definitely be a result of the changes in the command registry, but I have not been able to successfully debug it.

The other commands (fetch, merge, etc.) are working.
But when I push, it seems the auth fail error does not trigger the auth prompt and instead silently swallows the error.

I get the push confirm dialog, and when I select "OK" to use the default branch, nothing happens afterward.

I have a breakpoint in line 922 of gitClient.js and can see the data from the request:

Code: 0
DetailedMessage: "Auth fail"
HttpCode: 401
JsonData: Object
Message: "Auth fail"
Severity: "Error"
__proto__: Object

I would expect the "handleSshAuthenticationError" code to kick in and prompt for the credentials in the slideout, the same way that Fetch does.  but something is dying a long the way.

Comment 1 Susan McCourt

2013-03-12 13:50:31 EDT

Gosia, could you help me out with this?  Looking at the git log, I suspect that I have caused this somehow, because there have been no other changes in the area of git commands.  However, I am not familiar with the code and it's a bunch of asynch deferreds, so I'm not sure where to watch for the handling of the auth error.  I only know that it is not triggered from the breakpoint mentioned above.

Comment 2 Susan McCourt

2013-03-13 10:46:23 EDT

Found it.  An embarrassing typo in the error handler during the bulk change of module names.  I should have seen this yesterday, sorry for the false alarm.  The error didn't show in gitCommands because there are hundreds of warnings covering them up.  

Pushed in
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=840712e261d6bd8ee8049c41b7cb907aac5ec669

Comment 3 Susan McCourt

2013-03-13 10:53:40 EDT

(In reply to comment #2)
> The error didn't show in gitCommands because there are hundreds of
> warnings covering them up.  

I'm lying.  It wouldn't have shown up as it's referring to something in another module that wasn't there.