Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 402823

Summary: should remember commit details across commits
Product: [ECD] Orion Reporter: Rafael Chaves <eclipse>
Component: GitAssignee: Project Inbox <orion.git-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: enhancement    
Priority: P3 CC: ken_walker
Version: 2.0   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Commit
none
Configuration User section of Git page none

Description Rafael Chaves CLA 2013-03-09 16:00:31 EST
I am asked for committer/author name/email every time I commit a change, which is quite annoying. Those 4 fields should be remembered, or at least default to the current user info.
Comment 1 Ken Walker CLA 2013-03-09 17:40:53 EST
There are a few git settings that can be remembered.  On the Settings Page->User Profile section there is both a Git Config section and also under that is a toggle to remember Git Credentials.  If you toggle this, your info can be persisted in local storage.  The next time you access a repository and the credentials dialog or popup comes up, there should be a toggle to remember it.

If these are not adequate please describe what you'd like.  I'm not going to close this bug unless you believe the description and options described above are enough.
Comment 2 Rafael Chaves CLA 2013-03-09 17:55:04 EST
My git credentials (required for pushing) are remembered. I am referring to that form dialog that pops up when *committing*. Those are never remembered, right?
Comment 3 Ken Walker CLA 2013-03-09 17:59:49 EST
You have to toggle that setting in the profile page.  Then the next time you are prompted there's a toggle to remember it.  I have this set and can just fetch and push without prompt.  If you clear your localStorage/cache then it will be forgotten.
Comment 4 Rafael Chaves CLA 2013-03-09 18:10:04 EST
Ken, are you talking about pushing or commit? The problem I am reporting is about commit time, not push.
Comment 5 Ken Walker CLA 2013-03-09 21:21:31 EST
Created attachment 228169 [details]
Commit

This is what I see when I commit
Comment 6 Rafael Chaves CLA 2013-03-10 04:21:51 EDT
Yeah, I figured we must not be seeing the same thing. This is what I see:

http://www.screenr.com/vDt7
Comment 7 Rafael Chaves CLA 2013-03-12 11:29:09 EDT
Ken, does this report make more sense now? Have you ever seen that behavior?
Comment 8 Ken Walker CLA 2013-03-12 13:58:07 EDT
Created attachment 228294 [details]
Configuration User section of Git page
Comment 9 Ken Walker CLA 2013-03-12 13:58:15 EDT
Ok, I needed to create a new user to see that dialog and try a bunch of scenarios.  So if you've already loaded a git repo BEFORE filling in the username and email address in the User profile section then it's empty and you will always get that prompt.  The solution is to unload your repository, and then load it back up.

To see if a name is assigned you can click on a repository in your list of repos, then scroll down to the bottom and see the name under Configuration (user.*).
Comment 10 Rafael Chaves CLA 2013-03-12 14:17:16 EDT
Ah, never noticed that configuration section in the repository itself. Makes sense as it is repository (or at least server) specific.

I just recloned one of the repos I already had and indeed the configuration section showed my git credentials, and when trying to commit, I was not asked for them. Yay! Thanks.

Now, knowing that behavior makes this more avoidable, but I'd still expect that if I didn't have the user name/email in my profile, I'd be asked to enter them once at commit time, and from there on that user name/email were automatically set for that repository, so I wouldn't be asked again in following commits.
Comment 11 Ken Walker CLA 2013-03-12 15:09:06 EDT
truth.  so do you want to close this bug and open a feature request as per comment 10?
Comment 12 Ken Walker CLA 2013-03-12 15:09:29 EDT
actually, I guess this does have the right title.
Comment 13 Rafael Chaves CLA 2013-03-13 13:14:48 EDT
See also bug 350012.
Comment 14 John Arthorne CLA 2015-05-05 14:52:10 EDT
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html