Bugzilla – Full Text Bug Listing
| Summary: | Move ETFW Version menu to preference page | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] PTP | Reporter: | Greg Watson <g.watson> | ||||||
| Component: | ETFw | Assignee: | Chris Navarro <cmnavarr> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | drwootton, hubert+eclipseorg | ||||||
| Version: | 7.0 | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | Macintosh | ||||||||
| OS: | Mac OS X | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | 397684 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Greg Watson
*** Bug 403047 has been marked as a duplicate of this bug. *** Created attachment 228315 [details]
patches org.eclipse.ptp.etfw
This adds a PreferenceInitializer, Preferences and PreferenceConstants classes/interfaces. The preference has been added to the ExternalToolsPreferencePage (rather than creating a new preference page). The default parser is set to jaxb.
Created attachment 228317 [details] patches etfw launch tab This patches the performance analysis launch tab to use the preference to select the parser UI to build instead of making the selection in the UI. I also removed the add/remove workflow buttons because this seems only clutter the UI since those buttons are not yet implemented. New profile tool workflows should probably be done in a preference, added to the contribution plugin that is part of bug 397685, or added in a new plugin project that uses the extension point created in bug 397684. Chris, can you make the same statements for this bug? Thanks. 1. I authored 100% of the content I'm contributing 2. I have the rights to contribute the content to Eclipse 3. I contribute the content under the EPL *** Bug 403050 has been marked as a duplicate of this bug. *** Darn, I didn't see this comment and realize I was holding up the process, sorry. There have been some changes that have been made to the classes that are part of this patch so it's probably going to require a manual application of the patch. The recent preference changes also break some of this patch. Should I try to re-work the patch so it's more in line with the current master branch? If you want to try to apply them as-is, then: I confirm that: 1) I have authored 100% of the content that I am contributing. 2) I have the right to contribute the content to Eclipse, and 3) I contribute the content under the EPL. (In reply to comment #4) > Chris, can you make the same statements for this bug? Thanks. > > 1. I authored 100% of the content I'm contributing > 2. I have the rights to contribute the content to Eclipse > 3. I contribute the content under the EPL Chris, when your committer paperwork is finished, you can go ahead and commit this. Thanks. A fix is committed to master. |