Bugzilla – Full Text Bug Listing
| Summary: | [CBI] Our repo is missing "o.e.jdt.core.compiler.batch" | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | David Williams <david_williams> |
| Component: | Releng | Assignee: | David Williams <david_williams> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P1 | CC: | daniel_megert, david_williams, irbull, john.arthorne, pascal.rapicault, pwebster, tjwatson |
| Version: | 4.2.1 | ||
| Target Milestone: | 4.3 M6 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Bug Depends on: | 385154 | ||
| Bug Blocks: | 372792, 393922, 402063 | ||
|
Description
David Williams
At the heart of things, this was always produced by custom callback in org.eclipse.jdt.core e.g. see bug 377437. Its basically and unsigned version of the normal jdt.core bundle, I believe. So, to fix this, might require fixing the "ejc.jar" problem first, in the new builds. Isn't this a duplicate of bug 385154? (In reply to comment #2) > Isn't this a duplicate of bug 385154? I think there is a part "JDT" needs to do, and then a couple of things "releng" needs to do, so not exact dup, but, 'depends on'. Well this was sure easy to fix, thanks to the magic of our monolithic build. http://git.eclipse.org/c/platform/eclipse.platform.releng.git/commit/?id=38f1df944865879a3a3fd4c2577b04a02caf0aaa I did waste 12 hours thinking there was a more complicated solution needed (involving products or new features in our tychobuilder project) because, during local test builds, in this initial approach, there were errors about how it could not find the plugin, but I think that was because I was trying to include org.eclipse.jdt.core.compiler.batch.source which eventually I figured out we do not build (as we did with PDE build) because it is not listed in http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/tree/pom.xml As far as I know, Virgo does not pull that, and if they did, I suspect they could leave without it, so as far as I'm concerned, we simply won't produce that particular source bundle any more. If anyone feels differently, please open a new bug (in jdt) and we'll address at some later point in time. This should be in Tuesday night's 8 PM build. (In reply to comment #4) > This should be in Tuesday night's 8 PM build. I tried to verify the fix but I'm not sure which repo you actually mean with "our repo". FWIW the batch compiler is neither available in http://download.eclipse.org/eclipse/updates/4.3-I-builds nor the JDT SDK repo: http://download.eclipse.org/eclipse/downloads/drops4/I20130312-2000/download.php?dropFile=org.eclipse.jdt.source-I20130312-2000.zip (In reply to comment #5) > (In reply to comment #4) > > This should be in Tuesday night's 8 PM build. > > I tried to verify the fix but I'm not sure which repo you actually mean with > "our repo". FWIW the batch compiler is neither available in > http://download.eclipse.org/eclipse/updates/4.3-I-builds > nor the JDT SDK repo: > http://download.eclipse.org/eclipse/downloads/drops4/I20130312-2000/download. > php?dropFile=org.eclipse.jdt.source-I20130312-2000.zip It is in ../eclipse/updates/4.3-I-builds/I20130312-2000/ but you can't "see" it with p2 UI since it is a bundle-only. No feature. That's always the way we've done it, since not intended to be selected by end-users, but if some other feature/product (e.g. Virgo) had a dependency on it, it would be found (by most build systems) or if someone used p2director, or if using b2 Aggregator or other tool can can browse repositories. (In reply to comment #6) > It is in ../eclipse/updates/4.3-I-builds/I20130312-2000/ OK, so you essentially verified the bug :-). |