Bugzilla – Full Text Bug Listing
| Summary: | The eclipse file is no longer symbolically linked to the real one from the Eclipse.app folder | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Thomas Watson <tjwatson> | ||||
| Component: | Releng | Assignee: | Paul Webster <pwebster> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | daniel_megert, david_williams, jan.sievers, john.arthorne, markus.kell.r, pwebster, thanh.ha | ||||
| Version: | 4.3 | ||||||
| Target Milestone: | 4.3 M6 | ||||||
| Hardware: | PC | ||||||
| OS: | Mac OS X | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 372792, 393922 | ||||||
| Attachments: |
|
||||||
|
Description
Thomas Watson
I noticed even Tycho's demo RCP project [1] does not create a symbolic link for me. I posted this issue on tycho-users [2]. [1] http://wiki.eclipse.org/Tycho/Demo_Projects/RCP_Application [2] http://dev.eclipse.org/mhonarc/lists/tycho-user/msg04062.html is the problem only in the created tar archive (but the symlink is presetn under under target/products/ ) ? If so, this is probably http://jira.codehaus.org/browse/PLXCOMP-117 (In reply to comment #2) > is the problem only in the created tar archive (but the symlink is presetn > under under target/products/ ) ? > > If so, this is probably http://jira.codehaus.org/browse/PLXCOMP-117 Yes, the symlink is present in the directory but not in the archive. I guess we're hitting the Plexus bug. (In reply to comment #3) > Yes, the symlink is present in the directory but not in the archive. I guess > we're hitting the Plexus bug. given that http://jira.codehaus.org/browse/PLXCOMP-117 is reported since 4 years, I think we need a short-term plan B here. first thing that comes to my mind is using http://ant.apache.org/manual/Tasks/tar.html and maven antrun plugin (*if* ant tar supports symlinks). I may find time to investigate if we can propose a fix for the plexus archiver bug (I did this in the past for another similar bug http://jira.codehaus.org/browse/PLXCOMP-207 ) but this will definitely take time until it's accepted and released. I can't help wonder why this was not detected earlier as the plexus bug has always been there. (In reply to comment #5) > I can't help wonder why this was not detected earlier as the plexus bug has > always been there. I believe symbolic links are only created for the Mac OSX packages and we haven't had very many Mac testers until now so it likely slipped through the cracks. (In reply to comment #6) > (In reply to comment #5) > > I can't help wonder why this was not detected earlier as the plexus bug has > > always been there. > > I believe symbolic links are only created for the Mac OSX packages and we > haven't had very many Mac testers until now so it likely slipped through the > cracks. That and the typical Mac user is not going to invoke the symbolically linked executable. Only crazies like me that want to get console output from the start to debug or get an osgi> prompt in a console. (In reply to comment #4) > (In reply to comment #3) > first thing that comes to my mind is using > http://ant.apache.org/manual/Tasks/tar.html although ant tar seems to have support for symlinks on implementation level - it does not pick up symlinks from the filesystem and it seems there is no way to configure them [1] - worse, it does not pick up unix permissions from file system [2] and you would have to configure e.g. execute permissions for each file explicitly (as opposed to plexus tar where this works out of the box) [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=40059 [2] http://stackoverflow.com/questions/1517297/how-can-i-use-the-ant-tar-task-and-preserve-file-permissions the way I see it the only short term workaround is to go antrun > exec with native tar Tom, could you try the version at http://build.eclipse.org/eclipse/builds/eclipse-SDK-test-macosx-cocoa.tar.gz PW (In reply to comment #9) > Tom, could you try the version at > http://build.eclipse.org/eclipse/builds/eclipse-SDK-test-macosx-cocoa.tar.gz > > PW It works for me. I see the link file there and it points to the correct executable. Created attachment 228361 [details]
Workaround for the mac - tar
David, what about this workaround for M6? Update the production script to use build.eclipse.org tar to get the correct symbolic links.
PW
(In reply to comment #11) > Created attachment 228361 [details] > Workaround for the mac - tar > > David, what about this workaround for M6? Update the production script to > use build.eclipse.org tar to get the correct symbolic links. > > PW I don't like it (having to work around someone else's bug) but won't object. I know in PDE build we often used "native zip" instead of ant's, for similar reasons. But, I'll let you commit. Thanks for the work around. Released as http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=413247308aadd0b08ab558a96f949672df229ddb Will the change to build-functions.sh be picked up by the next build? PW tycho bug 429809 may eventually provide a more general solution |