Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 402021

Summary:	TextStyler generates inconsistent style keywords
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Editor	Assignee:	Silenio Quarti <Silenio_Quarti>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Silenio_Quarti
Version:	2.0
Target Milestone:	3.0 M1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mark Macdonald

2013-02-28 10:45:40 EST

The style generated by textStyler.js for a "string" is 
> var stringStyle = {styleClass: "token-string"};

Note the hyphen. This is inconsistent with every other style it generates:
> var numberStyle = {styleClass: "token_number"};
> var keywordStyle = {styleClass: "token_keyword"};

It should probably be "token_string"

Comment 1 Silenio Quarti

2013-02-28 11:45:23 EST

I believe it got inconsistent because we were trying to making the classname the same between all the stylers.  I still think we need to standardize on some class names for all stylers, but I reverted the change for now.   This falls in to the work we are done for bug#401914.  Note that textTheme.js already generates a style sheet with token_string.

Fixed

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=4ce2d0d820aaeda4747406abc9233f3d60093b4c