Bug 401949

Description Mark Macdonald 2013-02-27 15:10:44 EST

The createUser() method of UsersService.js does not correctly fulfill its service call contract. It returns a promise that never fulfills. The code looks like this:

> createUser : function(userName, password, email, onLoad, onError) {
> 	var ret = new Deferred();
> 	xhr("POST", "../users", { //$NON-NLS-1$ //$NON-NLS-0$
> 		data: form.encodeFormData({
> 			login : userName,
> 			password : password,
> 			email: email
> 		}),
> 		load : function(jsonData, xhrArgs) {
> 			ret.resolve(jsonData);
> 		},
> 		error : function(error, ioArgs) {
> 			ret.reject(error.response || error);
> 		}
> 	});
> 	return ret;
> },

Because it uses orion/xhr here, the "load" and "error" parameters are never called (they're leftover dojoisms). As a result, "ret" never resolves, and the promise is left hanging.

This makes it impossible to chain more aync operations to the result of a UserService call.